Trying to publish a composition fails, throwing `Cannot read properties of undefined (reading 'Z9K1')` JS error
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DVrandecic
	Aug 2 2023, 11:21 PM

Description

Steps to replicate the issue (include links if applicable):

ne a user with Functioneer rights (it might be that Maintainer rights allow for that, I didn't try it out)
go to https://www.wikifunctions.org/w/index.php?title=Special:CreateObject&uselang=en&zid=Z14&Z14K1=Z801
click on the charon next to "Select Function"
Switch Type from Function call to Argument reference
Add Z801K1 into Key Id
Click Publish

What happens?:
Nothing

What should have happened instead?:
It should save the implementation as a new object.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Note that we are dealing with a builtin Function here. But https://www.wikifunctions.org/view/en/Z10015 worked

Reported by User:0xDeadbeef

Details

	Subject	Repo	Branch	Lines +/-
	Fix unsafe validator to not reach into undefined keys	mediawiki/extensions/WikiLambda	wmf/1.41.0-wmf.20	+114 -52
	Fix unsafe validator to not reach into undefined keys	mediawiki/extensions/WikiLambda	master	+114 -52

Customize query in gerrit

Event Timeline

DVrandecic created this task.Aug 2 2023, 11:21 PM

DVrandecic updated the task description. (Show Details)Aug 2 2023, 11:23 PM

From my console:

TypeError: Cannot read properties of undefined (reading 'Z9K1')
    at S.validateZObject (load.php?lang=en-gb&modules=ext.wikilambda.edit%7Cjquery%2Cvue&skin=vector-2022&version=t1wn5:45:66)
    at Array.<anonymous> (<anonymous>:308:706)
    at S.dispatch (<anonymous>:316:498)
    at S.dispatch (<anonymous>:315:470)
    at T.forEach.n.<computed> (<anonymous>:319:115)

gengh claimed this task.Aug 3 2023, 3:37 PM

Change 945615 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix unsafe validator to not reach into undefined keys

https://gerrit.wikimedia.org/r/945615

gerritbot added a project: Patch-For-Review.Aug 3 2023, 3:48 PM

Jdforrester-WMF changed the task status from Open to In Progress.Aug 3 2023, 3:56 PM

Jdforrester-WMF moved this task from Backlog to To deploy on the Abstract Wikipedia team board.

Change 945615 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix unsafe validator to not reach into undefined keys

https://gerrit.wikimedia.org/r/945615

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 3 2023, 4:00 PM

Change 944862 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] Fix unsafe validator to not reach into undefined keys

https://gerrit.wikimedia.org/r/944862

Change 944862 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] Fix unsafe validator to not reach into undefined keys

https://gerrit.wikimedia.org/r/944862

Mentioned in SAL (#wikimedia-operations) [2023-08-03T16:17:26Z] <jforrester@deploy1002> Started scap: Backport for [[gerrit:944862|Fix unsafe validator to not reach into undefined keys (T343393)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-03T16:19:03Z] <jforrester@deploy1002> jforrester: Backport for [[gerrit:944862|Fix unsafe validator to not reach into undefined keys (T343393)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-03T16:28:24Z] <jforrester@deploy1002> Finished scap: Backport for [[gerrit:944862|Fix unsafe validator to not reach into undefined keys (T343393)]] (duration: 10m 57s)

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Aug 3 2023, 4:28 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2023, 4:30 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 3 2023, 5:00 PM

Impressive speed!

Trying to publish a composition fails, throwing `Cannot read properties of undefined (reading 'Z9K1')` JS errorClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Trying to publish a composition fails, throwing `Cannot read properties of undefined (reading 'Z9K1')` JS error
Closed, ResolvedPublicBUG REPORT
Actions