Page MenuHomePhabricator

Publish button is always active on Add language dialog
Closed, ResolvedPublicBUG REPORT

Description

Split from T343380

Steps to replicate the issue (include links if applicable):

  • As a non-logged (or a logged user) on wikifucntions open a page, e.g. Z41 or Z1199
  • Click on "x languages" button to expand
  • In the open popup "Labels in other languages", click on Add language

What happens?:

  • the displayed dialog "Labels in other languages" will have an active button Continue to publish

Screen Shot 2023-08-03 at 8.44.42 PM.png (1×2 px, 279 KB)

What should have happened instead?:

  • the publish button should be inactive if a user hasn't typed anything in the dialog's fields:

Event Timeline

Etonkovidova renamed this task from "Add to Publish button is always active on Add language dialog.Aug 4 2023, 12:19 AM
Etonkovidova created this task.

Change 945773 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Propagate canEdit into About dialogs to restrict edition

https://gerrit.wikimedia.org/r/945773

About widget computes a property called canEditObject to disable the pecil/edit button on top corner of the widget.

In my patch, I have propagated this property into the other dialogs to restrict the rest of edit actions:

  • "Add language" button should be disabled
  • "Continue to publish" button should be disabled
  • Text and alias fields should be disabled

Here's some screenshots:

Screenshot from 2023-08-04 14-51-17.png (662×1 px, 65 KB)

Screenshot from 2023-08-04 14-51-43.png (781×1 px, 91 KB)

Jdforrester-WMF changed the task status from Open to In Progress.Aug 4 2023, 1:56 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.

Change 945773 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Propagate canEdit into About dialogs to restrict edition

https://gerrit.wikimedia.org/r/945773