Page MenuHomePhabricator

Label editor throws away input when selecting language
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Open a page, e.g. Z41
  • Expand “X languages”
  • Click “Add language”
  • Enter something into the inviting, already-focused label input
  • Move to the Language input and select a language

What happens?:
The label input is cleared, throwing away what I already wrote.

What should have happened instead?:
The input should have been kept.

Other information (browser name/version, screenshots, etc.):
Before selecting a language (even before typing into the label field), the “Continue to publish” button is enabled. I haven’t tested what happens if I click it. After selecting a language, it becomes disabled until you type something into the label field again.

Event Timeline

Jdforrester-WMF moved this task from To triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF subscribed.

If we correctly selected the language selector first, this wouldn't be as much a problem. :-( (Though people could still trigger it if they tabbed/clicked away and then returned.)

Change 945632 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Don't clear the About edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945632

Change 945632 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Don't clear the About edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945632

Change 945648 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] Don't clear the About edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945648

Change 945648 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] Don't clear the About edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945648

Mentioned in SAL (#wikimedia-operations) [2023-08-03T20:59:43Z] <jforrester@deploy1002> Synchronized php-1.41.0-wmf.20/extensions/WikiLambda/: T343402 and T343380 (duration: 07m 50s)

Etonkovidova subscribed.

Checked on wikifuncitons wmf.20 - the issue (clearing users' input when a user moves to a different field) is fixed.

Other information (browser name/version, screenshots, etc.): Before selecting a language (even before typing into the label field), the “Continue to publish” button is enabled. I haven’t tested what happens if I click it. After selecting a language, it becomes disabled until you type something into the label field again.

I filed it as a separate task - T343498: Publish button is always active on Add language dialog for the above issue.

Change 945762 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix: Don't clear the About edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945762

Change 945762 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] AboutEditMetadataDialog: Don't clear the edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945762

Change 945663 had a related patch set uploaded (by Jforrester; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] AboutEditMetadataDialog: Don't clear the edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945663

Change 945663 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.41.0-wmf.20] AboutEditMetadataDialog: Don't clear the edit fields when we pick a new language

https://gerrit.wikimedia.org/r/945663

Mentioned in SAL (#wikimedia-operations) [2023-08-04T12:25:16Z] <jforrester@deploy1002> Synchronized php-1.41.0-wmf.20/extensions/WikiLambda: T343380 and T343400 (duration: 10m 12s)