Page MenuHomePhabricator

Fix guiding messages conflicting with text box
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
eamedina
Aug 4 2023, 1:08 PM
Referenced Files
F37854507: 2023-09-29_10-31-24.png
Sep 29 2023, 9:12 PM
F37854612: 2023-09-29_14-08-34.png
Sep 29 2023, 9:12 PM
F37854501: 2023-09-29_10-11-11.png
Sep 29 2023, 9:12 PM
F37854487: 2023-09-29_10-01-31.png
Sep 29 2023, 9:12 PM
F37854485: 2023-09-29_10-01-05.png
Sep 29 2023, 9:12 PM
F37854483: 2023-09-29_10-00-43.png
Sep 29 2023, 9:12 PM
F37854480: 2023-09-29_10-00-21.png
Sep 29 2023, 9:12 PM
F37173795: image.png
Aug 4 2023, 1:08 PM

Description

We can use percentages instead of hardcoded pixels to adjust for all devices.

image.png (1×796 px, 552 KB)

QA Results - Beta

ACStatusDetails
1Different screen size device, and make sure the text box doesn’t conflict with the guide message box. here

Event Timeline

eamedina triaged this task as Medium priority.
eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

Change 949991 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/Wikistories@master] Fix conflicting divs

https://gerrit.wikimedia.org/r/949991

Change 949991 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Fix conflicting divs

https://gerrit.wikimedia.org/r/949991

@hueitan and @eamedina The text box doesn’t conflict with the guide message box as seen from the screenshots below. I will move this to design signoff. Thanks for all your work again!

Status: ✅PASS
Environment: Beta: 1.41.0-alpha (7463ce2)
OS: macOS Sonoma 14.0, Windows 11
Browser: Chrome 117, Firefox 117, Safari 17, Edge 117
Device: MBA M2
Emulated Device:: BrowserStack for Edge
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Cat#

✅AC1: Different screen size device, and make sure the text box doesn’t conflict with the guide message box.

Chrome- iPadMiniChrome- Galaxy FoldChrome- Surface DuoChrome- iPhone 12 Pro
2023-09-29_10-00-21.png (908×697 px, 504 KB)
2023-09-29_10-00-43.png (771×600 px, 166 KB)
2023-09-29_10-01-05.png (849×726 px, 339 KB)
2023-09-29_10-01-31.png (951×564 px, 316 KB)
FireFox- iPad MiniEdge- Galaxy S20 UltraSafari- 750x1334
2023-09-29_10-11-11.png (1×2 px, 1 MB)
2023-09-29_14-08-34.png (967×1 px, 518 KB)
2023-09-29_10-31-24.png (1×925 px, 1 MB)