Page MenuHomePhabricator

Provide a message when user can not run a function because lack of activated implementation
Closed, ResolvedPublic

Description

In https://www.wikifunctions.org/view/en/Z10167 there are no activated implementation so user can not run the function. The user should know why they can not run the function. Probably we should provide a message "you can not run the function because there is no activated implementation".

P.S. Once community have an approval process of implementations, it may be difficult to review multiple interconnected functions because functions can not be run until approved implementations exist.

Event Timeline

Another reproduce:

This will display "The search has provided no result." which is a really confusing text

Change 946626 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] FunctionEvaluator: Inform the user that they can't run a function without implementations

https://gerrit.wikimedia.org/r/946626

Change 946626 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionEvaluator: Inform the user that they can't run a function without implementations

https://gerrit.wikimedia.org/r/946626

Jdforrester-WMF changed the task status from Open to In Progress.Aug 16 2023, 4:17 AM
Jdforrester-WMF claimed this task.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to To deploy on the Abstract Wikipedia team board.
Etonkovidova subscribed.

Checked in wikifunctions wmf.26 - the functions without approved implementations, e.g. https://www.wikifunctions.org/view/en/Z10167 or https://www.wikifunctions.org/wiki/Z10782 have a message displayed: "This function has no approved implementations." (the Run function button remains inactive even with the valid user input)

Screen Shot 2023-09-19 at 4.27.47 PM.png (1×2 px, 185 KB)

Another reproduce:

This will display "The search has provided no result." which is a really confusing text

Thanks, @Bugreporter for the comment! There are several issues with messaging to users on Special:RunFunction. I filed them in a separate ticket T346852.