Page MenuHomePhabricator

CirrusSearch uses invalid hook name "PageUndeleteHook"
Closed, ResolvedPublic

Description

Added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/947314 by @dcausse - correct name is "PageUndeleteComplete", as the commit message acknowledges.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 948660 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] Fix hook name for PageUndeleteComplete in extension.json

https://gerrit.wikimedia.org/r/948660

I have marked this as a blocker for the train as the mention code change is new to that train.
The impact of not blocking the train is only visible on undeletion of pages. New undeleted pages would not be re-added to the search index until the next edit is done on that page.

Feel free to remove as blocker, because undeletion is not a main action and it can repair itself on next edit.

Change 948660 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Fix hook name for PageUndeleteComplete in extension.json

https://gerrit.wikimedia.org/r/948660