Page MenuHomePhabricator
Create Task
Maniphest T343724

1.41.0-wmf.22 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.41.0-wmf.22
Release Date
Aug 14 2023, 12:00 AM

2023 week 33 1.41-wmf.22 Changes wmf/1.41.0-wmf.22

This MediaWiki Train Deployment is scheduled for the week of Monday, August 14th:

Monday August 14thTuesday, August 15thWednesday, August 16thThursday, August 17thFriday
Backports only.Branch wmf.22 and deploy to Group 0 Wikis.Deploy wmf.22 to Group 1 Wikis.Deploy wmf.22 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.22 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.21
Next: 1.41.0-wmf.23
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.22operations/mediawiki-configmaster+328 -328
group1 wikis to 1.41.0-wmf.22operations/mediawiki-configmaster+548 -548
group0 wikis to 1.41.0-wmf.22operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.22operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.22mediawiki/corewmf/1.41.0-wmf.22+986 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Aug 7 2023, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2023, 3:33 PM
Umherirrender added subscribers: Urbanecm, Umherirrender.Aug 7 2023, 5:01 PM
Risky Patch! 🚂🔥
Tgr added a subtask: T343291: [betacluster] Cannot login - UserLogin RuntimeException: Failed to run getConfiguration.php.Aug 7 2023, 5:30 PM
RhinosF1 subscribed.Aug 8 2023, 6:42 AM
tstarling closed subtask T343291: [betacluster] Cannot login - UserLogin RuntimeException: Failed to run getConfiguration.php as Resolved.Aug 8 2023, 11:02 AM
Lucas_Werkmeister_WMDE subscribed.EditedAug 8 2023, 1:26 PM
Risky Patch! 🚂🔥
Jdlrobson added subscribers: ovasileva, Jdrewniak, Jdlrobson and 2 others.Aug 11 2023, 6:29 PM
Risky Patch! 🚂🔥

We are changing the inline script at the top of all wiki pages which is risky by nature. We have taken precautions to ensure this goes smoothly so I am quite optimistic about the deploy but flagging it nevertheless.

Potential problems are:

  • Performance degradationn
  • Could potentially cause breakage to the limited width toggle used on Vector 2022 for anonymous users.
  • Test plan:
  • We will be monitoring the performance metrics during rollout.
  • We will be performing additional testing as part of roll out to group 1 wikis
  • Revert plan: Rollback train, or Revert patch, or …

If any issue is raised on the group 1 deploy, it's preferable to hold the train until we understand the issue and have agreement about next steps.
Note reverting is likely to cause a temporary client error spike relating to mw.user.clientPrefs not being undefined. It's safe to ignore that. If the errors do not subside that could indicate some kind of cache pollution.

In event of a functionality issue
Please refer to @ovasileva and @Jdrewniak about what to do. Do not attempt rollback without their input. It's preferable for web team to prepare follow up patches than attempt a full rollback.

In event of a performance issue
Please defer to @Krinkle around decisions here. It is safe to revert the patche(s) by design. The old implementation and new implementation should be backwards compatible both ways and it doesn't have any impact on product-side. Please do let @Jdrewniak know if a revert is happening.

Two revert patches have been prepared that should cherry pick cleanly to wmf22 those are:

  • Affected wikis:

All wikis

  • IRC contact

I (@Jdlrobson) am not going to be available but the following people are capable hands:

  • @Catrope and @Krinkle are familiar with the change. Please defer to @Krinkle about any performance issues when considering a revert.
    • Web team contact is @Jdrewniak for any other issues.
Jdlrobson mentioned this in T344069: Merge follow up work to client preferences.Aug 11 2023, 6:32 PM
Jdlrobson mentioned this in T339268: [anon prefs] Implement inline script.Aug 11 2023, 6:35 PM
thcipriani assigned this task to brennen.Aug 11 2023, 11:35 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Escape Goats🐐).
Umherirrender added a subtask: T344187: CirrusSearch uses invalid hook name "PageUndeleteHook".Aug 14 2023, 8:36 PM
Umherirrender closed subtask T344187: CirrusSearch uses invalid hook name "PageUndeleteHook" as Resolved.Aug 14 2023, 10:25 PM
gerritbot added a comment.Aug 15 2023, 2:07 AM

Change 948688 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.22] Branch commit for wmf/1.41.0-wmf.22

https://gerrit.wikimedia.org/r/948688

gerritbot added a project: Patch-For-Review.Aug 15 2023, 2:07 AM
gerritbot added a comment.Aug 15 2023, 2:23 AM

Change 948688 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.22] Branch commit for wmf/1.41.0-wmf.22

https://gerrit.wikimedia.org/r/948688

gerritbot added a comment.Aug 15 2023, 3:01 AM

Change 948707 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/948707

gerritbot added a comment.Aug 15 2023, 3:02 AM

Change 948707 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/948707

Stashbot added a comment.Aug 15 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-15T03:02:43Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.22 refs T343724

Stashbot added a comment.Aug 15 2023, 3:56 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-15T03:56:25Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.22 refs T343724 (duration: 53m 42s)

taavi added a subtask: T344223: User logging in on mw-on-k8s triggers "RuntimeException: firejail is enabled, but cannot be found".Aug 15 2023, 10:41 AM
Krinkle closed subtask T344223: User logging in on mw-on-k8s triggers "RuntimeException: firejail is enabled, but cannot be found" as Resolved.Aug 16 2023, 4:10 PM
gerritbot added a comment.Aug 16 2023, 6:01 PM

Change 949565 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/949565

gerritbot added a comment.Aug 16 2023, 6:02 PM

Change 949565 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/949565

Stashbot added a comment.Aug 16 2023, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T18:10:14Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.22 refs T343724

dancy subscribed.Aug 16 2023, 6:11 PM

I will leave the train on group0 for an hour before moving to group1 today.

gerritbot added a comment.Aug 16 2023, 7:31 PM

Change 949594 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/949594

gerritbot added a comment.Aug 16 2023, 7:31 PM

Change 949594 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/949594

Stashbot added a comment.Aug 16 2023, 7:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T19:40:46Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.22 refs T343724

Stashbot added a comment.Aug 16 2023, 7:48 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T19:48:00Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.22 refs T343724 (duration: 07m 14s)

Urbanecm added a subtask: T344391: Interwiki user rights changes not being logged correctly.Aug 17 2023, 12:32 PM
Urbanecm closed subtask T344391: Interwiki user rights changes not being logged correctly as Resolved.Aug 17 2023, 3:38 PM
gerritbot added a comment.Aug 17 2023, 6:00 PM

Change 950002 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/950002

gerritbot added a comment.Aug 17 2023, 6:01 PM

Change 950002 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.22

https://gerrit.wikimedia.org/r/950002

Stashbot added a comment.Aug 17 2023, 6:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T18:08:58Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.22 refs T343724

thcipriani reassigned this task from brennen to dancy.Aug 17 2023, 7:38 PM
thcipriani updated Other Assignee, added: jnuche; removed: dancy.
thcipriani added a subscriber: brennen.
phuedx mentioned this in T295619: Cookie value sent in HTTP requests changes too frequently.Aug 18 2023, 9:35 AM
dancy closed this task as Resolved.Aug 18 2023, 2:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL