Page MenuHomePhabricator
Create Task
Maniphest T340248

1.41.0-wmf.20 deployment blockers
Closed, ResolvedPublicRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.41.0-wmf.20
Release Date
Jul 31 2023, 12:00 AM

2023 week 31 1.41-wmf.20 Changes wmf/1.41.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, July 31st:

Monday July 31stTuesday, August 1stWednesday, August 2ndThursday, August 3rdFriday
Backports only.Branch wmf.20 and deploy to Group 0 Wikis.Deploy wmf.20 to Group 1 Wikis.Deploy wmf.20 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.19
Next: 1.41.0-wmf.21
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+328 -328
group1 wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+546 -546
group0 wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+546 -546
group1 wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+546 -546
group0 wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.20operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.20mediawiki/corewmf/1.41.0-wmf.20+986 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jun 23 2023, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2023, 6:57 PM
Jdlrobson added a subtask: T342557: TypeError: undefined is not a constructor (evaluating 'new mw.libs.ve.SwitchConfirmDialog') / TypeError: mw.libs.ve.SwitchConfirmDialog is not a constructor.Jul 24 2023, 3:50 PM
Urbanecm added a subtask: T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki'.Jul 26 2023, 5:26 PM
Urbanecm_WMF added a subtask: T342733: SkinException: No registered builder available for ..Jul 26 2023, 5:32 PM
Urbanecm closed subtask T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki' as Resolved.Jul 26 2023, 6:24 PM
Krinkle closed subtask T342733: SkinException: No registered builder available for . as Resolved.Jul 27 2023, 3:11 PM
thcipriani assigned this task to dancy.Jul 27 2023, 10:28 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani added a project: Release-Engineering-Team (Escape Goats🐐).
Lucas_Werkmeister_WMDE subscribed.EditedJul 31 2023, 1:59 PM

Risky patch comment superseded by T340248#9057917 below.

gerritbot added a comment.Aug 1 2023, 2:07 AM

Change 942801 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.20] Branch commit for wmf/1.41.0-wmf.20

https://gerrit.wikimedia.org/r/942801

gerritbot added a project: Patch-For-Review.Aug 1 2023, 2:07 AM
gerritbot added a comment.Aug 1 2023, 2:22 AM

Change 942801 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.20] Branch commit for wmf/1.41.0-wmf.20

https://gerrit.wikimedia.org/r/942801

gerritbot added a comment.Aug 1 2023, 3:01 AM

Change 943654 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/943654

gerritbot added a comment.Aug 1 2023, 3:02 AM

Change 943654 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/943654

Stashbot added a comment.Aug 1 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T03:02:44Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.20 refs T340248

Stashbot added a comment.Aug 1 2023, 3:54 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T03:54:50Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.20 refs T340248 (duration: 52m 06s)

Lucas_Werkmeister_WMDE added a comment.Aug 1 2023, 8:17 AM
Risky Patch! 🚂🔥

This supersedes my earlier risky patch comment, as additional changes got merged before the branch cut. I’m posting this as a separate comment to ensure the new version is noticed.

Lucas_Werkmeister_WMDE closed subtask T343192: Repeated notification icons on 1.41.0-wmf.20 when using legacy Vector as Resolved.Aug 1 2023, 10:07 AM
gerritbot added a comment.Aug 1 2023, 6:07 PM

Change 944302 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944302

gerritbot added a comment.Aug 1 2023, 6:07 PM

Change 944302 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944302

Stashbot added a comment.Aug 1 2023, 6:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-01T18:15:28Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.20 refs T340248

gerritbot added a comment.Aug 2 2023, 6:01 PM

Change 944971 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944971

gerritbot added a comment.Aug 2 2023, 6:02 PM

Change 944971 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944971

Stashbot added a comment.Aug 2 2023, 6:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-02T18:10:00Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.20 refs T340248

Stashbot added a comment.Aug 2 2023, 6:16 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-02T18:16:39Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.20 refs T340248 (duration: 06m 38s)

gerritbot added a comment.Aug 2 2023, 6:24 PM

Change 944975 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944975

gerritbot added a comment.Aug 2 2023, 6:25 PM

Change 944975 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944975

dancy added a subtask: T343375: Translation of some key namespaces ("Module:", others?) missing from 1.41.0-wmf.20, breaking any hewiki page that uses that.Aug 2 2023, 6:25 PM

Rolling the train back to group0 due to T343375.

Stashbot added a comment.Aug 2 2023, 6:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-02T18:32:01Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.20 refs T340248

Lucas_Werkmeister_WMDE added a comment.Aug 2 2023, 7:06 PM
In T340248#9064285, @dancy wrote:

Rolling the train back to group0 due to T343375.

That issue sounds a lot like it could be due to T340248#9057917 :/ I suggest you try reverting LocalisationCache: Load only core data if possible, it’s the most likely change to cause trouble of the three. (But you can also try reverting all three. None of them are urgently needed for anything, especially not anything in production; we might just have to revert something else in Wikibase if the core changes have to be removed again.)

gerritbot added a comment.Aug 2 2023, 8:55 PM

Change 944988 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944988

gerritbot added a comment.Aug 2 2023, 8:56 PM

Change 944988 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/944988

Stashbot added a comment.Aug 2 2023, 9:04 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-02T21:04:06Z] <dancy@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.20 refs T340248

Stashbot added a comment.Aug 2 2023, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-02T21:10:28Z] <dancy@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.20 refs T340248 (duration: 06m 21s)

dancy removed a subtask: T343375: Translation of some key namespaces ("Module:", others?) missing from 1.41.0-wmf.20, breaking any hewiki page that uses that.Aug 2 2023, 9:11 PM
Jdlrobson added a subtask: T343397: Wikidata descriptions in Search result overlay can overlap.Aug 3 2023, 4:49 PM
Jdlrobson added subscribers: ovasileva, Jdlrobson.

Per @ovasileva marking T343397 as a train blocker.

Jdlrobson added a comment.Aug 3 2023, 6:52 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/945646 has been cherry picked to the release branch. Train can continue once that patch has been merged.

gerritbot added a comment.Aug 3 2023, 7:43 PM

Change 945639 had a related patch set uploaded (by TrainBranchBot; author: Ahmon Dancy):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/945639

gerritbot added a comment.Aug 3 2023, 7:44 PM

Change 945639 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.20

https://gerrit.wikimedia.org/r/945639

Stashbot added a comment.Aug 3 2023, 7:53 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-03T19:53:01Z] <dancy> dancy@deploy1002 rebuilt and synchronized wikiversions files group2 wikis to 1.41.0-wmf.20 refs T340248

dancy removed a subtask: T343397: Wikidata descriptions in Search result overlay can overlap.Aug 3 2023, 7:54 PM
dancy closed this task as Resolved.Aug 4 2023, 3:21 PM
Lucas_Werkmeister_WMDE mentioned this in T343724: 1.41.0-wmf.22 deployment blockers.Aug 8 2023, 1:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL