Page MenuHomePhabricator

Wikidata descriptions in Search result overlay can overlap
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to mobile version of Wikimedia Commons or Wikinews in Portuguese
  • Type any letter in the search bar

What happens?:
The Wikidata description is in blue and the text overlaps the others.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

snapshot_commons.m.wikimedia.org_1691023665972.png (684×540 px, 177 KB)

snapshot_pt.m.wikinews.org_1691022648814.png (684×540 px, 157 KB)

Event Timeline

Edu triaged this task as Medium priority.Aug 3 2023, 12:53 AM
Aklapper raised the priority of this task from Medium to Needs Triage.Aug 3 2023, 8:16 AM
Aklapper added a project: MinervaNeue.

Thanks for reporting this. It's not broken, it only overlaps.

That overflow happens as .overlay.search-overlay li.page-summary { height: 70px; } and .overlay.search-overlay li.page-summary .wikidata-description { font-size: 13px; margin-top: 9px; are in place as CSS.

Screenshot from 2023-08-03 10-07-19.png (833×364 px, 158 KB)

Aklapper renamed this task from broken search results on mobile version to Wikidata descriptions in Search result overlay can overlap.Aug 3 2023, 8:17 AM
ovasileva raised the priority of this task from High to Unbreak Now!.Aug 3 2023, 4:49 PM
ovasileva subscribed.

Marking as UBN as this will affect search functionality across all wikis on mobile.

Change 945616 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Fix mobile search text overlapping

https://gerrit.wikimedia.org/r/945616

Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bfb5ece526/w

Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/bfb5ece526/w/

Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c96f24757a/w

Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c96f24757a/w/

Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f6b2630f23/w

Change 945646 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.20] Fix mobile search text overlapping

https://gerrit.wikimedia.org/r/945646

Change 945616 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix mobile search text overlapping

https://gerrit.wikimedia.org/r/945616

Change 945646 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.20] Fix mobile search text overlapping

https://gerrit.wikimedia.org/r/945646

Mentioned in SAL (#wikimedia-operations) [2023-08-03T19:16:30Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:945646|Fix mobile search text overlapping (T343397)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-03T19:20:07Z] <dancy@deploy1002> jdlrobson and dancy: Backport for [[gerrit:945646|Fix mobile search text overlapping (T343397)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-03T19:26:04Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:945646|Fix mobile search text overlapping (T343397)]] (duration: 09m 33s)

Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/f6b2630f23/w/

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Search results should not overlap.

IMG_9455.jpeg (2×1 px, 829 KB)

IMG_9456.jpeg (2×1 px, 800 KB)

Please take a look since I didn’t test this in beta.

Yep all good here. Thanks!