Page MenuHomePhabricator
Create Task
Maniphest T340247

1.41.0-wmf.19 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
dancy
Release Version
1.41.0-wmf.19
Release Date
Jul 24 2023, 12:00 AM

2023 week 30 1.41-wmf.19 Changes wmf/1.41.0-wmf.19

This MediaWiki Train Deployment is scheduled for the week of Monday, July 24th:

Monday July 24thTuesday, July 25thWednesday, July 26thThursday, July 27thFriday
Backports only.Branch wmf.19 and deploy to Group 0 Wikis.Deploy wmf.19 to Group 1 Wikis.Deploy wmf.19 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.19 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.18
Next: 1.41.0-wmf.20
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+328 -328
group1 wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+545 -545
group0 wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+545 -545
group1 wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+545 -545
group0 wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.19operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.19mediawiki/corewmf/1.41.0-wmf.19+986 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Jun 23 2023, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2023, 6:57 PM
Lucas_Werkmeister_WMDE added a subtask: T342209: EntitySchema CI broken: Error: Call to undefined method DifferenceEngine::localiseLineNumbers().Jul 19 2023, 9:56 AM
Lucas_Werkmeister_WMDE closed subtask T342209: EntitySchema CI broken: Error: Call to undefined method DifferenceEngine::localiseLineNumbers() as Resolved.Jul 19 2023, 1:22 PM
thcipriani assigned this task to jnuche.Jul 20 2023, 7:53 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dancy.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
tstarling subscribed.Jul 21 2023, 12:16 AM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/936132
  • Summary:
    • Diff cache keys are changed so that previous diff cache entries will no longer be read. This may cause an appserver CPU spike. But there have been several other changes of this kind in recent years, without incident, so serious consequences are unlikely.
    • It is a large and complex patch.
  • Test plan:
    • Monitor for appserver resource exhaustion.
  • Places to monitor:
  • Revert plan: Rollback train
  • Affected wikis: all
  • IRC contact: TimStarling (UTC+10)
  • UBN Task Projects/tags: Community-Tech
  • Would you like to backport this change rather than ride the train?: No
daniel subscribed.EditedJul 24 2023, 7:25 AM
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/809295
  • Summary:
    • This causes rate limit checks to be performed implicitly when checking permissions.
    • Risk 1: We may end up checking the rate limit twice, so it will trigger too soon. There is protection against this in the code, but who knows.
    • Risk 2: The code for checking permissions is called much more often. This may degrade performance of some operations. The code tries to avoid checking permissions unnecessarily, especially for the "read" permission, but who knows.
  • Test plan:
    • Extensive phpunit test coverage.
    • Many code paths trigger rate limit checks, if something goes wrong we'll notice soon.
  • Places to monitor:
  • Revert plan: Revert the patch or roll back the train. No persistent data is effected.
  • Affected wikis: all
  • IRC contact: Daniel Kinzler (duesen), Tim Starling
  • UBN Task Projects/tags: Platform Engineering
gerritbot added a comment.Jul 25 2023, 2:07 AM

Change 941047 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.19] Branch commit for wmf/1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941047

gerritbot added a project: Patch-For-Review.Jul 25 2023, 2:07 AM
gerritbot added a comment.Jul 25 2023, 2:22 AM

Change 941047 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.19] Branch commit for wmf/1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941047

gerritbot added a comment.Jul 25 2023, 7:55 AM

Change 941316 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941316

gerritbot added a comment.Jul 25 2023, 7:56 AM

Change 941316 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941316

Stashbot added a comment.Jul 25 2023, 7:57 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-25T07:57:03Z] <jnuche@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.19 refs T340247

Stashbot added a comment.Jul 25 2023, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-25T08:49:39Z] <jnuche@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.19 refs T340247 (duration: 52m 35s)

gerritbot added a comment.Jul 25 2023, 8:54 AM

Change 941365 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941365

gerritbot added a comment.Jul 25 2023, 8:54 AM

Change 941365 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941365

Stashbot added a comment.Jul 25 2023, 9:01 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-25T09:01:32Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.19 refs T340247

gerritbot added a comment.Jul 26 2023, 8:05 AM

Change 941779 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941779

gerritbot added a comment.Jul 26 2023, 8:06 AM

Change 941779 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941779

Stashbot added a comment.Jul 26 2023, 8:14 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T08:14:19Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.19 refs T340247

Stashbot added a comment.Jul 26 2023, 8:34 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T08:34:15Z] <jnuche@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.19 refs T340247 (duration: 19m 56s)

jnuche added a subtask: T342733: SkinException: No registered builder available for ..Jul 26 2023, 9:22 AM
gerritbot added a comment.Jul 26 2023, 11:11 AM

Change 941898 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941898

gerritbot added a comment.Jul 26 2023, 11:12 AM

Change 941898 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941898

Stashbot added a comment.Jul 26 2023, 11:19 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T11:19:04Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.19 refs T340247

jnuche added a comment.Jul 26 2023, 11:21 AM

Rolled back to group0 since there is a chance T342733 could be impacting users: T342733#9043895

Urbanecm added a subtask: T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki'.Jul 26 2023, 11:33 AM
Urbanecm_WMF added a subtask: T342744: CirrusSearch\Profile\SearchProfileException: Cannot load a profile type rescore_function_chains: growth_underlinked_chain not found.Jul 26 2023, 2:22 PM
gerritbot added a comment.Jul 26 2023, 3:49 PM

Change 941957 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941957

gerritbot added a comment.Jul 26 2023, 3:49 PM

Change 941957 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/941957

jnuche added a comment.Jul 26 2023, 3:51 PM

All three blockers have fixes backported for 1.41.0-wmf.19. Rolling forward to group1 again.

Stashbot added a comment.Jul 26 2023, 3:56 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T15:56:54Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.19 refs T340247

Stashbot added a comment.Jul 26 2023, 4:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-26T16:03:51Z] <jnuche@deploy1002> Synchronized php: group1 wikis to 1.41.0-wmf.19 refs T340247 (duration: 06m 56s)

Urbanecm removed a subtask: T342747: Special:UserRights in interwiki mode: Wikimedia\Assert\PreconditionException: Expected MediaWiki\User\UserIdentityValue to belong to the local wiki, but it belongs to 'metawiki'.Jul 26 2023, 5:26 PM
Urbanecm_WMF removed a subtask: T342733: SkinException: No registered builder available for ..Jul 26 2023, 5:32 PM
jnuche removed a subtask: T342744: CirrusSearch\Profile\SearchProfileException: Cannot load a profile type rescore_function_chains: growth_underlinked_chain not found.Jul 27 2023, 7:50 AM
gerritbot added a comment.Jul 27 2023, 8:05 AM

Change 942317 had a related patch set uploaded (by TrainBranchBot; author: Jaime Nuche):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/942317

gerritbot added a comment.Jul 27 2023, 8:06 AM

Change 942317 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.19

https://gerrit.wikimedia.org/r/942317

Stashbot added a comment.Jul 27 2023, 8:15 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-27T08:15:59Z] <jnuche@deploy1002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.19 refs T340247

thcipriani closed this task as Resolved.Jul 28 2023, 10:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits