Page MenuHomePhabricator
Create Task
Maniphest T344391

Interwiki user rights changes not being logged correctly
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Have userrights-interwiki
  • Go to Special:UserRights on meta and assign user rights to a user on another wiki (such as AntiCompositeNumber@testwiki )

What happens?:
The user rights are assigned, but it is logged as a Meta user rights change.
See https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=53251946

What should have happened instead?:
The change should have been logged as an interwiki user rights change, like https://meta.wikimedia.org/wiki/Special:Log?type=rights&page=User%3AAntiCompositeNumber%40nlwiki&wpFormIdentifier=logeventslist

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
cross-wiki userrights: Add SpecialUserRights::getDisplayUsernamemediawiki/corewmf/1.41.0-wmf.22+23 -5
cross-wiki userrights: Add SpecialUserRights::getDisplayUsernamemediawiki/coremaster+23 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT343724 1.41.0-wmf.22 deployment blockers
 ResolvedBUG REPORTUmherirrenderT344391 Interwiki user rights changes not being logged correctly

Event Timeline

AntiCompositeNumber created this task.Aug 17 2023, 1:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2023, 1:57 AM
AntiCompositeNumber added a comment.Aug 17 2023, 1:58 AM

Please test future Special:UserRights changes with interwiki user rights before deploying to production. This is getting silly.

Vermont subscribed.Aug 17 2023, 2:07 AM
AntiCompositeNumber added a project: MediaWiki-User-management.Aug 17 2023, 2:13 AM
Xaosflux subscribed.Aug 17 2023, 8:53 AM
Umherirrender claimed this task.Aug 17 2023, 10:32 AM
Umherirrender removed a project: Temporary accounts.
gerritbot added a comment.Aug 17 2023, 10:57 AM

Change 949939 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayName

https://gerrit.wikimedia.org/r/949939

gerritbot added a project: Patch-For-Review.Aug 17 2023, 10:57 AM
Urbanecm subscribed.Aug 17 2023, 12:23 PM

Highlighting T342763: Add testing for Special:UserRights's interwiki mode. Completing that task seems to be a must long-term.

Urbanecm mentioned this in T342763: Add testing for Special:UserRights's interwiki mode.Aug 17 2023, 12:23 PM
gerritbot added a comment.Aug 17 2023, 12:27 PM

Change 949582 had a related patch set uploaded (by Urbanecm; author: Umherirrender):

[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949582

Urbanecm triaged this task as Unbreak Now! priority.Aug 17 2023, 12:32 PM

This causes data pollution in production => train blocker.

Urbanecm added a parent task: T343724: 1.41.0-wmf.22 deployment blockers.Aug 17 2023, 12:32 PM
gerritbot added a comment.Aug 17 2023, 12:41 PM

Change 949939 merged by jenkins-bot:

[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949939

gerritbot added a comment.Aug 17 2023, 1:21 PM

Change 949582 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername

https://gerrit.wikimedia.org/r/949582

Stashbot mentioned this in T316079: Bump threshold for confidence score on link recommendation service suggestions.Aug 17 2023, 1:23 PM
Stashbot mentioned this in T255309: Remove UserRightsProxy and replace its usages with UserGroupManager (remove in 1.42).

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:05Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]]

Stashbot added a comment.Aug 17 2023, 1:23 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:55Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.c

Xaosflux added a comment.Aug 17 2023, 1:28 PM

Initial test in production passed:

https://meta.wikimedia.org/w/index.php?title=Special:Redirect/logid/53257074

Stashbot added a comment.Aug 17 2023, 1:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:28:52Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] (duration: 05m 46s)

Maintenance_bot removed a project: Patch-For-Review.Aug 17 2023, 1:30 PM
Urbanecm added a comment.Aug 17 2023, 1:31 PM

This is fixed for most cases now (k8s deployment didn't finish properly, once that is fixed, we can resolve this).

Urbanecm_WMF mentioned this in T344446: Notification received from metawiki instead of target site when group modified on metawiki.Aug 17 2023, 3:33 PM
Urbanecm closed this task as Resolved.Aug 17 2023, 3:38 PM

Resolved everywhere.

Umherirrender added a comment.Aug 17 2023, 3:52 PM
In T344391#9099019, @Urbanecm wrote:

This causes data pollution in production => train blocker.

Just for the record: The data pollution is about 6 log entries - https://meta.wikimedia.org/w/index.php?title=Special:Log/rights&offset=20230817132800S257074&limit=7

Xaosflux added a comment.Aug 17 2023, 4:11 PM

I reapplied the rights change for the end user on svwiki, only one that anyone would likely ever go looking for

Urbanecm added a comment.Aug 17 2023, 6:46 PM
In T344391#9099765, @Umherirrender wrote:
In T344391#9099019, @Urbanecm wrote:

This causes data pollution in production => train blocker.

Just for the record: The data pollution is about 6 log entries - https://meta.wikimedia.org/w/index.php?title=Special:Log/rights&offset=20230817132800S257074&limit=7

Yes, as the issue was fixed fairly promptly. Would be worse, if it was left unfixed for a couple of days (and nearly unrecoverable, as there is no way to determine which database was actually used).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits