The UserRightsProxy was used to get/set groups for the users in foreign wikis. We need to remove all usages of this class, since now the correct way of accessing groups for users in the foreign wikis is to use UserGroupManagerFactory to create a manager pointing to the correct domain.
CodeSearch: https://codesearch.wmcloud.org/search/?q=UserRightsProxy&files=&excludeFiles=&repos=
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release | |||
| Open | None | T274211 Finish hard-deprecation and removal of User methods depecated prior to MW 1.36 | |||
| Resolved | • Pchelolo | T234921 Factor group membership management out of User class | |||
| Resolved | Umherirrender | T275148 Prepare User group methods for hard deprecation | |||
| Resolved | None | T255309 Remove UserRightsProxy and replace its usages with UserGroupManager (remove in 1.42) | |||
| Resolved | Umherirrender | T337590 Assert correct wiki for the user identity in UserGroupManager for cross-wiki group changes/reading |
Change 762064 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/core@master] Formally deprecate UserRightsProxy
Change 762064 merged by jenkins-bot:
[mediawiki/core@master] Formally deprecate UserRightsProxy
Something interesting came out while grepping usages: T301642. That needs to be fixed somehow. Making it not use UserrightsPage at all would be nice.
What should be used for invalidateCache? Should UserRightsManager have something that can do that, or should it go elsewhere?
UserRightsProxy is only there for changing user rights cross-wiki. There is UserGroupManager::clearCache(), which cleans cached group memberships for some user identity. I don't think more is needed since changing the user rights cross-wiki doesn't actually touch the user table.
It changes the user table for the other wiki, right? Surely that's why UserRightsProxy::invalidateCache exists to begin with?
I'll try to give my two cents, but @Zabe and @Urbanecm probably have a better understanding of the intended and current semantics.
So here's my current take:
One more thing for context, because I saw it discussed elsewhere and now I can't find it: Title and WikiPage are guaranteed to be local. Making them support non-local pages would break that guarantee and violate LSP!
Darn. Ok then.
I think it should be still possible to do the following:
Note the following code in the constructor of UserrightsdPage:
// TODO don't hard code false, use interwiki domains. See T14518 $this->userGroupManager = ( $userGroupManagerFactory ?? $services->getUserGroupManagerFactory() ) ->getUserGroupManager( false );
My suggestion above should fix that, I hope.
So a basic question: if I have the ID of a non-local wiki, how do I find out the corresponding database domain? This is necessary to implement UserRightsProxy::invalidateCache as a method of UserrightsPage.
For now we can assume that the wiki ID *is* the database domain. Or at least we can assume that the LoadBalancer will treat it as an alias.
Change 786318 had a related patch set uploaded (by Simetrical; author: Simetrical):
[mediawiki/core@master] Remove UserRightsProxy
Change 787917 had a related patch set uploaded (by Simetrical; author: Simetrical):
[mediawiki/extensions/CentralAuth@master] Try converting special page to UserIdentity
Change 787920 had a related patch set uploaded (by Simetrical; author: Simetrical):
[mediawiki/extensions/Echo@master] Don't mention deprecated UserRightsProxy
Change 787920 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Don't mention deprecated UserRightsProxy
Change 787917 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove mentions of deprecated UserRightsProxy
Change 890510 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] [DNM] PoC: Create a UserIdentityCacheUpdater service
Change 890510 merged by jenkins-bot:
[mediawiki/core@master] user: Move UserRightsProxy::invalidateCache to UserFactory
Change 914900 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] user: Assert wikiId in UserGroupManager
Change 914900 merged by jenkins-bot:
[mediawiki/core@master] user: Assert wikiId in UserGroupManager
Change 923706 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights
Change 923706 merged by jenkins-bot:
[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights
Change 941516 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/GlobalUserrights@master] Adjust doc type to UserIdentity
Change 941519 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/BatchUserRights@master] Use cross-wiki aware UserIdentityLookup on Special:BatchUserRights
Change 941522 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/CentralAuth@master] Inline calls to CentralAuthGroupMembershipProxy and remove proxy
Change 941876 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/core@master] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"
Change 941877 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/core@wmf/1.41.0-wmf.19] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"
Change 941877 merged by jenkins-bot:
[mediawiki/core@wmf/1.41.0-wmf.19] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"
Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:00:51Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]]
Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:02:29Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)
Mentioned in SAL (#wikimedia-operations) [2023-07-26T14:13:25Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:941877|Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights" (T255309 T342747)]] (duration: 12m 33s)
Change 941968 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] user: Call UserFactory::invalidateCache for user group changes
Change 941516 merged by Umherirrender:
[mediawiki/extensions/GlobalUserrights@master] Adjust doc type to UserIdentity
Change 941876 merged by jenkins-bot:
[mediawiki/core@master] Revert "specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights"
Change 941513 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] maintenance: Remove UserRightsProxy from CreateAndPromote::addLogEntry
Change 941522 abandoned by Umherirrender:
[mediawiki/extensions/CentralAuth@master] Inline calls to CentralAuthGroupMembershipProxy and remove proxy
Reason:
I am go with If2722377dcce5349b4ed8dc2507f9e7a1dcaa9a5
Change 941513 merged by jenkins-bot:
[mediawiki/core@master] maintenance: Remove UserRightsProxy from CreateAndPromote::addLogEntry
Change 944188 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights
Change 941968 abandoned by Umherirrender:
[mediawiki/core@master] user: Call UserFactory::invalidateCache for user group changes
Reason:
Moved to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/944188
Change 941519 merged by jenkins-bot:
[mediawiki/extensions/BatchUserRights@master] Remove cross-wiki user right change support from Special:BatchUserRights
Change 944188 merged by jenkins-bot:
[mediawiki/core@master] specials: Use cross-wiki aware UserIdentityLookup on Special:UserRights
Change 949939 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayName
Change 949582 had a related patch set uploaded (by Urbanecm; author: Umherirrender):
[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername
Change 949939 merged by jenkins-bot:
[mediawiki/core@master] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername
Change 949582 merged by jenkins-bot:
[mediawiki/core@wmf/1.41.0-wmf.22] cross-wiki userrights: Add SpecialUserRights::getDisplayUsername
Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:05Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]]
Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:23:55Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.c
Mentioned in SAL (#wikimedia-operations) [2023-08-17T13:28:52Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:949582|cross-wiki userrights: Add SpecialUserRights::getDisplayUsername (T344391 T255309)]], [[gerrit:949577|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]], [[gerrit:949576|revalidateLinkRecommendations: Make it possible to revalidate based on score (T316079)]] (duration: 05m 46s)
Change 950003 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] cross-wiki userrights: Restore hook compatibility
Change 950003 merged by jenkins-bot:
[mediawiki/core@master] cross-wiki userrights: Restore hook compatibility
Change 953329 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/core@master] user: Hard-deprecate UserRightsProxy
Change 953329 merged by jenkins-bot:
[mediawiki/core@master] user: Hard-deprecate UserRightsProxy
Change 966656 had a related patch set uploaded (by Daniel Kinzler; author: Tim Starling):
[mediawiki/core@master] Remove UserRightsProxy
Change 786318 abandoned by Umherirrender:
[mediawiki/core@master] Remove UserRightsProxy
Reason:
It's done, the class was now removed with Icb3395dfc53a4441b667f001ac1227f36d1f2e8d