Page MenuHomePhabricator

Special:GlobalUserRights no longer works on accounts with a space in their username
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

image.png (546×1 px, 63 KB)

What should have happened instead?:
I see an userrights form, such as the following:

image.png (1×1 px, 275 KB)

Other information (browser name/version, screenshots, etc.):

This is possible to workaround by entering the space version of the username to the username field at the top of Special:GlobalUserRights. The userrights form displays and it is possible to (un)check groups. Once submitted via the "Save user groups" button, the error message depicted as F37565689 displays, but the userrights changes are saved currently (and if done quickly enough, even the success bubble message displays correctly.

This bug is annoying, as the links on SRGP for users with spaces are currently broken.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 950153 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembership: Normalize usernames

https://gerrit.wikimedia.org/r/950153

Urbanecm triaged this task as High priority.

Change 950153 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SpecialGlobalGroupMembership: Normalize usernames

https://gerrit.wikimedia.org/r/950153

Change 950071 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.22] SpecialGlobalGroupMembership: Normalize usernames

https://gerrit.wikimedia.org/r/950071

Change 950071 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.22] SpecialGlobalGroupMembership: Normalize usernames

https://gerrit.wikimedia.org/r/950071

Mentioned in SAL (#wikimedia-operations) [2023-08-21T14:57:05Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:950071|SpecialGlobalGroupMembership: Normalize usernames (T344495)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-21T14:58:35Z] <taavi@deploy1002> taavi and urbanecm: Backport for [[gerrit:950071|SpecialGlobalGroupMembership: Normalize usernames (T344495)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-21T15:05:52Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:950071|SpecialGlobalGroupMembership: Normalize usernames (T344495)]] (duration: 08m 47s)