Change 950270 abandoned by WMDE-Fisch:

[mediawiki/extensions/FileExporter@master] Replace use of old un-namespaced Database class

Reason:

Not used, false positive.

https://gerrit.wikimedia.org/r/950270

Change 950271 abandoned by WMDE-Fisch:

[mediawiki/extensions/FileImporter@master] Replace use of old un-namespaced Database class

Reason:

Not used, false positive.

https://gerrit.wikimedia.org/r/950271

Change 950312 abandoned by WMDE-Fisch:

[mediawiki/extensions/TwoColConflict@master] Replace use of old un-namespaced Database class

Reason:

Not used, false positive.

https://gerrit.wikimedia.org/r/950312

Change 950276 abandoned by TheDJ:

[mediawiki/extensions/GeoData@master] Replace use of old un-namespaced Database class

Reason:

false positive

https://gerrit.wikimedia.org/r/950276

Change 950246 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ActiveAbstract@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950246

Change 950274 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/FundraisingTranslateWorkflow@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950274

Change 950258 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cite@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950258

Change 950277 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/GlobalPreferences@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950277

Change 950278 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/GlobalUsage@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot picked up the word "Database" in a plain text comment.

https://gerrit.wikimedia.org/r/950278

Change 950280 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/IPInfo@master] Replace use of old un-namespaced Database class

Reason:

Not sure what happened here. The files don't contain the class name anywhere.

https://gerrit.wikimedia.org/r/950280

Change 950269 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/EventLogging@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950269

Change 950249 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ArticlePlaceholder@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950249

Change 950268 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/EventBus@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950268

Change 950265 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/DonationInterface@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950265

Change 950254 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/CategoryTree@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950254

Change 950262 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/CommonsMetadata@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950262

Change 950259 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/CodeMirror@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950259

Change 950263 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ConfirmEdit@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950263

Change 950261 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Collection@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950261

Change 950252 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/BounceHandler@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950252

Change 950260 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Cognate@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950260

Change 950250 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Babel@master] Replace use of old un-namespaced Database class

Reason:

False match. Babel does have it's own class with the name "Database".

https://gerrit.wikimedia.org/r/950250

Change 950251 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/BetaFeatures@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950251

Change 950248 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/AntiSpoof@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950248

Change 950284 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/LoginNotify@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950284

Change 950302 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/SiteMatrix@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950302

Change 950299 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/QuickSurveys@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950299

Change 950296 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageViewInfo@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950296

Change 950305 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TemplateStyles@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950305

Change 950303 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/SpamBlacklist@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950303

Change 950307 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TheWikipediaLibrary@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950307

Change 950309 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TitleBlacklist@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950309

Change 950324 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikimediaEvents@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950324

Change 950317 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Wikibase@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950317

Change 950279 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/GlobalWatchlist@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950279

Change 950311 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TranslationNotifications@master] Replace use of old un-namespaced Database class

Reason:

Looks like the bot got confused by the `@group Database`.

https://gerrit.wikimedia.org/r/950311

Change 950310 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Translate@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950310

Change 950275 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Gadgets@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950275

Change 950322 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikidataPageBanner@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950322

Change 950313 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/UploadWizard@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950313

Change 950301 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Scribunto@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950301

Change 950314 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/UrlShortener@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950314

Change 950287 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Math@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950287

Change 950285 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/MachineVision@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950285

Change 950293 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageAssessments@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950293

Change 950290 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/OAuth@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950290

Change 950273 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Flow@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950273

Change 950264 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ContentTranslation@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950264

Change 950281 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/JsonConfig@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950281

Change 950282 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950282

Change 950315 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/VisualEditor@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950315

Change 950318 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikibaseCirrusSearch@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950318

Change 950323 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikimediaEditorTasks@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950323

Change 950298 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PropertySuggester@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950298

Change 950320 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikibaseMediaInfo@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950320

Change 950288 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/MobileFrontend@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950288

Change 950297 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ProofreadPage@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950297

Change 950300 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/ReadingLists@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950300

Change 950289 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Newsletter@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950289

Change 950267 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/EntitySchema@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950267

Change 950308 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TimedMediaHandler@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950308

Change 950319 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950319

Change 950316 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikiLambda@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950316

Change 950321 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/WikibaseQualityConstraints@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950321

Change 950295 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageTriage@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950295

Change 950306 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Thanks@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950306

Change 950294 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/PageImages@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950294

Change 950291 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/OAuthRateLimiter@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950291

Change 950283 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Linter@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950283

Change 950266 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Echo@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950266

Change 950257 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/CirrusSearch@master] Replace use of old un-namespaced Database class

Reason:

False match.

https://gerrit.wikimedia.org/r/950257

Change 950292 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Replace use of old un-namespaced Database class

https://gerrit.wikimedia.org/r/950292

Change 950227 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop old class aliases

https://gerrit.wikimedia.org/r/950227

And CI breaks immediately :/

1) CentralAuthDatabaseManagerTest::testGetCentralDBValidIndexes with data set "DB_PRIMARY" (-2)
PHPUnit\Framework\MockObject\UnknownTypeException: Class or interface "IDatabase" does not exist

Change 953233 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/CentralAuth@master] Add missing IDatabase imports

https://gerrit.wikimedia.org/r/953233

(Note that CentralAuth not being part of core’s gate-and-submit is quite intentional, see T321864 and T333541.)

Change 953233 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add missing IDatabase imports

https://gerrit.wikimedia.org/r/953233

Recheck on the EntitySchema change where CI was broken is still running, but so far the result looks good (it’s already progressed past the point where the error happened last time).

o_O Somehow this is also causing additional EntitySchema CI errors:

1) EntitySchema\Tests\Integration\MediaWiki\Actions\RestoreSubmitActionTest::testRestoreSubmit
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'abc'
+'def'

/workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Actions/RestoreSubmitActionTest.php:72

2) EntitySchema\Tests\Integration\MediaWiki\Actions\RestoreViewActionTest::testRestoreView
Failed asserting that '<div class="mw-message-box cdx-message cdx-message--block mw-message-box-error cdx-message--error"><span class="cdx-message__icon"></span><div class="cdx-message__content">The revision you tried to restore is identical to the current revision. Nothing to do.</div></div><p id="mw-returnto">Return to <a href="/index.php/EntitySchema:E1234" title="EntitySchema:E1234">EntitySchema:E1234</a>.</p>\n
' contains "<ins class="diffchange diffchange-inline">abc</ins>".

/workspace/src/extensions/EntitySchema/tests/phpunit/integration/MediaWiki/Actions/RestoreViewActionTest.php:82

I can reliably reproduce both of them locally and they both go away if I check out the parent change of the “drop old class aliases” merge.

Restoring the IDatabase alias alone is enough to make the EntitySchema tests pass locally (i.e. it doesn’t seem to be one of the other aliases). I assume another import is missing somewhere, but I can’t figure out where…

EntitySchema CI issue split into T345164: EntitySchema CI broken since IDatabase alias was removed to avoid cluttering the discussion here further. (But if anyone has ideas how the removal of a class alias could cause these issues, please comment there, I’m pretty perplexed at the moment.)

Change 953277 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/FlaggedRevs@master] Add missing import for namespaced IDatabase

https://gerrit.wikimedia.org/r/953277

Change 953277 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Add missing import for namespaced IDatabase

https://gerrit.wikimedia.org/r/953277