Page MenuHomePhabricator

Star symbol appears in page name after saving changes and staying on page
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

How I stumble upon this

To make sure, I closed the tab and did steps 1-3 again. But this time, I try the next page (https://id.wikisource.org/wiki/Halaman:UU_Nomor_11_Tahun_2006.pdf/28) and I didn't click preview, straight to save changes. Using the same option, the bug happens again.

What happens?:
A random star symbol appears in the page name, as shown in the red circle.

SS_20230823_1102.png (600×1 px, 120 KB)

What should have happened instead?:
I don't think that should appear.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • I use Microsoft Edge 109.0.1518.115 (Official build) (32-bit)
  • The screenshot already included above.

Event Timeline

Aklapper renamed this task from Star symbol appears in the page name after saving changes and stay on the page to Star symbol appears in page name after saving changes and staying on page.Aug 23 2023, 7:53 AM
Aklapper updated the task description. (Show Details)

Looking at the source code (rEPRP modules/page.editinsequence/EditorController.js (at 42dd1131)), it seems to represent (the number of?) unsaved edits. However, without looking at the code, I would’ve probably never figured this out, so it should probably rethought how to present this piece of information.

Looking at the source code (rEPRP modules/page.editinsequence/EditorController.js (at 42dd1131)), it seems to represent (the number of?) unsaved edits. However, without looking at the code, I would’ve probably never figured this out, so it should probably rethought how to present this piece of information.

It should only be one '*' based on how similar behaviour is exhibited by text editors like notepad.

One of the more recent commits appears to have borken it :(