Page MenuHomePhabricator

Send Client Hints headers on 304 response for action=history view.
Closed, DeclinedPublic

Description

When a user loads ?action=history for the first time, the Accept-CH header is sent. However, if the user then refreshes the page, the server may decide to send a 304 (Not Modified) response. This response does not include the Client Hints Accept-CH header.

The data received from sending this header is not yet read or stored, however, this may be done in the future. This would potentially be done for rollback.

Event Timeline

Change 952539 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] [WIP] Run new hook once OutputPage responds with 304 response

https://gerrit.wikimedia.org/r/952539

Change 952541 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] clienthints: Send Accept-CH header on 304 responses

https://gerrit.wikimedia.org/r/952541

Blocked on whether Client Hints data should be collected via the API or using HTTP headers for rollbacks.

Change 952539 abandoned by Dreamy Jazz:

[mediawiki/core@master] Run new hook on 304 response in OutputPage::checkLastModified

Reason:

Not needed for the foreseeable future.

https://gerrit.wikimedia.org/r/952539

Change 952541 abandoned by Dreamy Jazz:

[mediawiki/extensions/CheckUser@master] [WIP] clienthints: Send Accept-CH header on 304 responses

Reason:

Not needed for the foreseeable future.

https://gerrit.wikimedia.org/r/952541