Page MenuHomePhabricator
Create Task
Maniphest T344846

wikipedia.org wordmark sprite in wrong position on resolutions <=480px
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The Wikipedia wordmark logo does not show, instead you see half of the WMF logo.

What should have happened instead?:

The Wikipedia wordmark logo should show in full above the text "The Free Encyclopedia".

Other information (browser name/version, screenshots, etc.):

Looks like the logo sprite has been changed and the background-position property on .svg-Wikipedia_wordmark just needs adjusting within the max-width: 480px media query.

Spotted on Google Chrome on desktop using responsive mode (both Mac and PC) and replicated on Google Pixel 6 Pro

image.png (616×885 px, 57 KB)

Details

SubjectRepoBranchLines +/-
Bumping portals to masteroperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

ehughes created this task.Aug 23 2023, 6:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2023, 6:05 PM
Opencooper subscribed.EditedSep 1 2023, 4:18 AM

Someone also recently reported this on reddit. I was able to reproduce this on Android using both Google Chrome and Firefox. As ehuges said, the positioning of the wordmark gets messed up at the 480px breakpoint, so likely a CSS issue. The root domain of the project is pretty user-visible, so hopefully this can be triaged soon.

Rchard2scout added subscribers: Jdforrester-WMF, Rchard2scout.Sep 4 2023, 2:17 PM

Seems like this is caused by T323399. @Jdforrester-WMF, looks like you worked on that?

DLynch subscribed.Sep 4 2023, 2:50 PM

This has already been fixed by https://gerrit.wikimedia.org/r/c/wikimedia/portals/+/953275 which was tagged against that other task -- I think it's just waiting for a deployment window to go out.

gerritbot added a comment.Sep 4 2023, 3:26 PM

Change 954709 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Bumping portals to master

https://gerrit.wikimedia.org/r/954709

gerritbot added a project: Patch-For-Review.Sep 4 2023, 3:26 PM
gerritbot added a comment.Sep 4 2023, 3:31 PM

Change 954709 merged by jenkins-bot:

[operations/mediawiki-config@master] Bumping portals to master

https://gerrit.wikimedia.org/r/954709

Jdrewniak subscribed.Sep 4 2023, 3:48 PM

Sorry for the delay, just deployed the fix.

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 4:10 PM
Jdforrester-WMF added a comment.Sep 5 2023, 11:27 AM

I'm still getting the old CSS locally; is it cached?

DLynch added a comment.Sep 5 2023, 2:57 PM

Looks okay to me right now, so the caching issue may have passed.

image.png (834×858 px, 106 KB)

Jdforrester-WMF added a comment.Sep 5 2023, 3:01 PM
In T344846#9143023, @DLynch wrote:

Looks okay to me right now, so the caching issue may have passed.

image.png (834×858 px, 106 KB)

Still broken for me; might be a esams vs. eqiad caching issue?

Rchard2scout added a comment.Sep 5 2023, 3:11 PM

Still broken for me too, and I'm in the Netherlands, so I'm assuming I'm connected to esams.

Aklapper closed this task as Resolved.Nov 12 2023, 11:09 AM

Fixed now, also using esams.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL