Mockup | Current |
The header should have a dividing line underneath it, on both steps 1 and 2.
kostajh | |
Aug 24 2023, 11:52 AM |
F37670106: image.png | |
Sep 7 2023, 1:18 PM |
F37670104: image.png | |
Sep 7 2023, 1:18 PM |
F37670102: image.png | |
Sep 7 2023, 1:18 PM |
F37670100: image.png | |
Sep 7 2023, 1:18 PM |
F37626190: image.png | |
Aug 24 2023, 11:52 AM |
F37626193: image.png | |
Aug 24 2023, 11:52 AM |
Mockup | Current |
The header should have a dividing line underneath it, on both steps 1 and 2.
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
form: Set border for header | mediawiki/extensions/ReportIncident | master | +3 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T337566 [EPIC]: Incident Reporting System - Minimal Testable Product (MTP) | |||
Resolved | • eigyan | T344906 Fix discrepancies between existing code and design specifications | |||
Declined | BUG REPORT | kostajh | T344908 Header should have dividing line |
@kostajh it looks like the Dialog header is set to have a dividing line in the header on scroll only or am I misinterpreting the codex design? Also in the image where the header dividing line is shown, we can also see scroll is enabled.
Change 955727 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):
[mediawiki/extensions/ReportIncident@master] form: Set border for header
@JSengupta-WMF @Madalina the above patch implements a border for the header, please let us know if this is what you want.
Desktop step one | |
Desktop step two | |
Mobile step one | |
Mobile step two |
... or, as @eigyan says, I am misinterpreting the designs, and the dialogs shouldn't have any border unless there is overflow content. Looking again at the Codex dialog examples, the only one that shows a border is the one with overflowing content. In which case, we can decline this task. @JSengupta-WMF, please let me know what you prefer to do for this task.
Per Codex, there's no border below the title ("Report Incident") on the desktop dialog component. There is for mobile.
Per T344908#9150130 and T344909#9177754, it looks like Codex only adds the header border when content overflows the viewport. As such, I am declining this task.
Change 955727 abandoned by Kosta Harlan:
[mediawiki/extensions/ReportIncident@master] form: Set border for header
Reason:
Declined the task T344908#9177761