Page MenuHomePhabricator
Create Task
Maniphest T345432

TextInput: Remove TextInput component from Wikilambda codebase
Closed, ResolvedPublic
Actions

Description

Description

Due to significant design differences that required programmatic behavior, we created WlTextInput component as a wrapper of CdxTextInput.
However, these design requirements are not there anymore, which means that the WlTextInput component is now an unnecessary layer.

Remove the TextInput component and replace the instances of wl-text-input with direct cdx-text-input instances

Completion checklist

Details

SubjectRepoBranchLines +/-
Replace wl-text-input with cdx-text-input componentsmediawiki/extensions/WikiLambdamaster+184 -331
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Sep 1 2023, 12:34 PM
Jdforrester-WMF subscribed.Sep 13 2023, 2:12 PM

We're using WlTextInput for character limits, and per T331000 upstream don't want to add this as a feature, instead saying we should roll our own as part of using Field - so we should do T345433 first? In T345876 they added an example of how to do this in the official docs.

• CCoxwell-WMF claimed this task.Sep 15 2023, 10:41 PM
gerritbot added a comment.Sep 15 2023, 10:43 PM

Change 957980 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] [WIP] replace wl-text-input with cdx-text-input

https://gerrit.wikimedia.org/r/957980

gerritbot added a project: Patch-For-Review.Sep 15 2023, 10:43 PM
• CCoxwell-WMF added a subscriber: AAlhazwani-WMF.Sep 15 2023, 10:49 PM
In T345432#9163936, @Jdforrester-WMF wrote:

We're using WlTextInput for character limits, and per T331000 upstream don't want to add this as a feature, instead saying we should roll our own as part of using Field - so we should do T345433 first? In T345876 they added an example of how to do this in the official docs.

@Jdforrester-WMF, after talking to you and @AAlhazwani-WMF, i'm only using codex's TextInput in two specific cases: ZString (because of DefaultView's complexity) and ZMonolingualString (because of the chip inside the input field). every other use of our bespoke TextInput component will be replaced with codex's Field.

AAlhazwani-WMF awarded a token.Sep 18 2023, 9:24 AM
Jdforrester-WMF changed the task status from Open to In Progress.Sep 21 2023, 4:53 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF lowered the priority of this task from High to Medium.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Sep 27 2023, 3:06 AM

Change 957980 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] replace wl-text-input with cdx-text-input

https://gerrit.wikimedia.org/r/957980

gerritbot added a comment.Oct 4 2023, 6:36 PM

Change 957980 had a related patch set uploaded (by Ccoxwell; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] replace wl-text-input with cdx-text-input

https://gerrit.wikimedia.org/r/957980

gerritbot added a comment.Oct 5 2023, 2:51 PM

Change 961268 had a related patch set uploaded (by Genoveva Galarza; author: Ccoxwell):

[mediawiki/extensions/WikiLambda@master] Replace wl-text-input with cdx-text-input components

https://gerrit.wikimedia.org/r/961268

• CCoxwell-WMF added a comment.Oct 12 2023, 11:11 PM

currently blocked by https://phabricator.wikimedia.org/T348811

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Oct 24 2023, 2:34 PM
gerritbot added a comment.Oct 24 2023, 6:16 PM

Change 961268 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Replace wl-text-input with cdx-text-input components

https://gerrit.wikimedia.org/r/961268

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 24 2023, 7:00 PM
Jdforrester-WMF removed a project: Patch-For-Review.Oct 25 2023, 1:45 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Nov 6 2023, 8:34 PM
Jdforrester-WMF closed this task as Resolved.Nov 17 2023, 6:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits