Show IP button returns to unrevealed state when updating and changing settings or filters on Recent Changes
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Sep 4 2023, 2:53 PM

Description

What is the problem?

If I click "Show IP" on Special:RecentChanges to reveal an IP address, if I

change settings
change filters
update (i.e. when new changes come in)

the IP address is no longer revealed.

Steps to reproduce problem

Make sure IP Reveal is enabled
1. e.g. add $wgGroupPermissions['sysop']['checkuser-temporary-account'] = true; to your LocalSettings.php, login as an admin, go to Special:Preferences and check Enable revealing IP addresses for temporary accounts)
Make sure there are some recent changes by a temporary user
1. e.g. add $wgAutoCreateTempUser['enabled'] = true; to your LocalSettings.php and make a few edits while logged out
Go to Special:RecentChanges
Click "Show IP"
Remove one of the lozenges under "Active filters", or change the number of results to show

Expected behavior: IP you revealed in step 4 remains revealed
Observed behavior: It is no longer revealed, instead "Show IP" is shown again

Environment

Browser: Firefox 102.
Wiki(s): local docker CheckUser 2.5 (560ca5a) 01:05, 2 September 2023.

Screenshots

Details

	Subject	Repo	Branch	Lines +/-
	Check for recent IP reveals on wikipage content refresh	mediawiki/extensions/CheckUser	master	+16 -12

Customize query in gerrit

Related Objects

Mentioned Here: rECHU560ca5ac5f74: Merge "Use real type hints in CheckUser where possible"

Event Timeline

dom_walden created this task.Sep 4 2023, 2:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2023, 2:53 PM

Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Sep 5 2023, 10:42 AM

TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Anti-Harassment.May 14 2024, 4:15 PM

Tchanders edited projects, added Temporary accounts (Create/update essential tools/anti-abuse management); removed Temporary accounts.Jun 11 2024, 2:24 PM

STran claimed this task.Jun 20 2024, 9:32 AM

Change #1047935 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Check for recent IP reveals on wikipage content refresh

https://gerrit.wikimedia.org/r/1047935

gerritbot added a project: Patch-For-Review.Jun 20 2024, 10:06 AM

Change #1047935 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Check for recent IP reveals on wikipage content refresh

https://gerrit.wikimedia.org/r/1047935

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2024, 12:31 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 20 2024, 1:00 PM

Tchanders added a project: Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jun 21 2024, 9:59 AM

Tchanders moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jun 25 2024, 9:57 AM

I have verified the new code has been implemented and is functioning and displaying as expected:

kostajh closed this task as Resolved.Jun 27 2024, 4:54 AM

	F55901317: image.png
	Jun 27 2024, 3:23 AM

	F55901309: image.png
	Jun 27 2024, 3:23 AM

	F55900515: image.png
	Jun 27 2024, 3:23 AM

	F55900527: image.png
	Jun 27 2024, 3:23 AM

Show IP button returns to unrevealed state when updating and changing settings or filters on Recent ChangesClosed, ResolvedPublicBUG REPORTActions