Page MenuHomePhabricator
Create Task
Maniphest T345756

[SPIKE] Exploratory testing of new font size
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Following T343928 we want to run some QA of the new font size and how it impacts articles and gadgets. This should probably be done by Justin and Edward (Justin should help Edward identify things we would consider problematic).

Setup

  1. Run
mw.user.clientPrefs.set('vector-feature-custom-font-size', 'enabled')

to enable font size on one of the production Wikipedia's

(or use url parameter)

  1. Go through various articles noting articles/features where issues relating to font size occur.

Acceptance Criteria

Test the following:

  1. Article/main namespace
    1. Test on at least one article with a large table and infobox
  2. History page
    1. Explore filters, modals, tables, etc
  3. Recent changes
    1. Explore filters, modals, tables, etc
  4. VE
    1. Explore importing templates and other toolbar functionality
  5. Check through remaining namespaces - all other namespaces (https://en.wikipedia.org/wiki/Wikipedia:Namespace)

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 6 2023, 4:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2023, 4:58 PM
Jdlrobson added a subscriber: ovasileva.Sep 6 2023, 4:58 PM

@ovasileva how would you imagine this one working?

Jdlrobson mentioned this in T343928: Add a simple feature flag to Vector for font size.Sep 6 2023, 4:58 PM
ovasileva triaged this task as High priority.Sep 6 2023, 5:07 PM
ovasileva added subscribers: JScherer-WMF, Edtadros.
In T345756#9147029, @Jdlrobson wrote:

@ovasileva how would you imagine this one working?

@Edtadros, @JScherer-WMF - any thoughts on this? Perhaps I can start with providing a list of pages to test and then we can schedule some time to come up with a plan?

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 11 2023, 2:09 PM
ovasileva renamed this task from Exploratory testing of new font size to [SPIKE] Exploratory testing of new font size.Sep 11 2023, 5:36 PM
ovasileva set the point value for this task to 2.
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva added a parent task: T313828: [EPIC] Typography: improve typography and allow for variable typography settings .
ovasileva changed the point value for this task from 2 to 3.
Jdlrobson assigned this task to ovasileva.Sep 18 2023, 5:31 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 21 2023, 4:51 PM
ovasileva updated the task description. (Show Details)Sep 21 2023, 9:41 PM
ovasileva edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6).
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Sep 25 2023, 5:26 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Sep 25 2023, 6:54 PM
ovasileva reassigned this task from ovasileva to Edtadros.Sep 26 2023, 4:40 PM
ovasileva moved this task from Doing to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.
Edtadros reassigned this task from Edtadros to Jdlrobson.EditedOct 4 2023, 1:41 AM

Test Result - Beta|Prod

Status: ❓Need More Info
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps
  1. Run
mw.user.clientPrefs.set('vector-feature-custom-font-size', 'enabled')

to enable font size on one of the production Wikipedia's

(or use url parameter)

?vectorclientpreferences=1
  1. Go through various articles noting articles/features where issues relating to font size occur.

Acceptance Criteria

Test the following:
✅ AC1: Article/main namespace - Test on at least one article with a large table and infobox

✅ AC2: History page - Explore filters, modals, tables, etc

✅ AC3: Recent changes - Explore filters, modals, tables, etc

✅ AC4: VE - Explore importing templates and other toolbar functionality

❓ AC5: Check through remaining namespaces - all other namespaces (https://en.wikipedia.org/wiki/Wikipedia:Namespace)

These are the only issues found:

screenshot 99.png (1×1 px, 308 KB)

screenshot 100.png (1×1 px, 390 KB)

The text in the Welcome box is already small and doesn't change.

screenshot 53.mov.gif (1×1 px, 852 KB)

Jdlrobson reassigned this task from Jdlrobson to ovasileva.Oct 4 2023, 3:51 PM
Jdlrobson added a subscriber: Jdrewniak.

@ovasileva @Jdrewniak @JScherer-WMF please see the cases above. ^

Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Oct 6 2023, 8:59 PM
ovasileva added a comment.Oct 9 2023, 9:39 AM
In T345756#9225540, @Jdlrobson wrote:

@ovasileva @Jdrewniak @JScherer-WMF please see the cases above. ^

These all look expected to me.

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1); removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Oct 10 2023, 4:55 PM
Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 4:56 PM
JScherer-WMF added a comment.Oct 11 2023, 7:39 PM
In T345756#9225540, @Jdlrobson wrote:

@ovasileva @Jdrewniak @JScherer-WMF please see the cases above. ^

These are all expected behaviour. DST will probably want to re-visit the scaling of the dropdown and checkbox in light of the text size changes, though.

ovasileva closed this task as Resolved.Oct 12 2023, 9:50 AM

Resolving this for now. Will revisit once we begin making changes.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL