Page MenuHomePhabricator

Include important Core / HTML / CSS / JS changes into future MediaWiki changelogs
Closed, InvalidPublic

Description

Example: From version 1.39 to version 1.40 there has been an important change in how images (File:image.jpg) are rendered from in 1.39 rendering an image to an img-element possibly wrapped in an a-element to now version 1.40 using figure and figcaption and generally a different HTML structure. Also is was changed too where the optional class parameter is rendered to.

This is an important, massive change that does affect a lot of wikis and possibly a lot of skins too.

We would like to request to have such important changes always prominently communicated. And the specific changes for 1.40 added here https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/REL1_40/RELEASE-NOTES-1.40

Event Timeline

These was an entry in 1.40, which links to on-wiki documentation of the changes:

* (T314318) $wgParserEnableLegacyMediaDOM – This setting has been changed, so
  the alternative modern HTML structure for media is now the default. You can
  disable it for now by over-riding this back to `true` in LocalSettings, but
  this configuration will be removed in future versions of MediaWiki. For more
  details, see the documentation at:
  https://www.mediawiki.org/wiki/Parsoid/Parser_Unification/Media_structure/FAQ

This was also mentioned back in 1.37:

* $wgParserEnableLegacyMediaDOM - This setting defaults to true, and enables
  the legacy media HTML structure in the output from the Parser.  The
  alternative modern HTML structure for media is described at
  https://www.mediawiki.org/wiki/Parsing/Media_structure
  In a future release of MediaWiki this option will default to false,
  so it's a good idea to test this setting on your wiki early and report
  any issues.

We could perhaps add a more explicit notification at the top of the release notes, but at this point we'd be talking about a backport to the 1.40 branch which would be included in the next security/minor release of 1.40.

2 people missed that. Mistake on our side.

You reply is much appreciated!

This ticket is therefore invalid as the suggestion is already in place. Closing.