Page MenuHomePhabricator
Create Task
Maniphest T345908

Adjust all "Start/Continue translation" buttons to redirect to the platform-specific translation editor
Closed, ResolvedPublic
Actions

Description

As described in the related task T328936, currently there are two separate versions of the translation dashboard, one on desktop and one on mobile. Our plan is to evolve the mobile dashboard to become the unified dashboard (the only one).

In this scenario, users will be able to access the unified dashboard regardless of their device, but we still want them to use the translation editor that is appropriate for their platform (mobile or desktop). To support this, we need all buttons and workflows that lead to the editor, to direct users to the right editor based on the user platform.

This task is basically an expansion of the T328936 task, to include all buttons/links, other than confirmation step buttons.

The buttons that should be tested for this task are:
A. "Confirm a translation" step

  1. Case 1: Expand article with new section
    • "New translation" button
    • "Translate section" button (when section is pre-selected through "section" URL param)
  2. Case 2: Create new page
    • "Start translation" button

B. "Pick a section" step

  • Click on section title to select it

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20230929mediawiki/extensions/ContentTranslationmaster+7 K -6 K
Confirm SX with prefilled section: Redirect to platform-specific editormediawiki/extensions/ContentTranslationmaster+22 -12
CX: Adjust "Pick a section" step to redirect to platform-specific editormediawiki/extensions/ContentTranslationmaster+22 -10
Customize query in gerrit

Related Objects
Search...

Event Timeline

ngkountas created this task.Sep 8 2023, 12:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 8 2023, 12:04 PM
ngkountas changed the task status from Open to In Progress.Sep 8 2023, 12:04 PM
ngkountas triaged this task as High priority.
ngkountas added a project: SectionTranslation.
ngkountas moved this task from Priority: Translation to In Progress on the Language-Team (Language-2023-July-September) board.
ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2023-July-September) board.Sep 8 2023, 12:06 PM
gerritbot added a comment.Sep 8 2023, 12:06 PM

Change 955918 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Adjust "Pick a section" step to redirect to platform-specific editor

https://gerrit.wikimedia.org/r/955918

gerritbot added a project: Patch-For-Review.Sep 8 2023, 12:06 PM
Pginer-WMF moved this task from Backlog to Core workflow on the SectionTranslation board.Sep 11 2023, 11:23 AM
gerritbot added a comment.Sep 23 2023, 6:32 AM

Change 955918 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX: Adjust "Pick a section" step to redirect to platform-specific editor

https://gerrit.wikimedia.org/r/955918

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 23 2023, 7:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 23 2023, 7:10 AM
ngkountas moved this task from In Review to Blocked on the Language-Team (Language-2023-July-September) board.Sep 25 2023, 4:54 PM
ngkountas moved this task from Blocked to Check after deployment on the Language-Team (Language-2023-July-September) board.Sep 28 2023, 3:05 PM
ngkountas moved this task from Check after deployment to In Review on the Language-Team (Language-2023-July-September) board.Sep 28 2023, 5:12 PM
ngkountas updated the task description. (Show Details)Sep 28 2023, 5:23 PM
ngkountas updated the task description. (Show Details)
ngkountas added a comment.Sep 28 2023, 5:29 PM

According to the -possibly not exhaustive- list, the only missing piece for this task to be completed is the "Translate section" button, inside the "Confirm a translation" step, a button that only appears when a preselected section title is provided inside "section" URL param.

The patch below fixes this issue.

Screencast of the issue before fix (local dev environment):

Screencast after fix (local dev environment):

gerritbot added a comment.Sep 28 2023, 5:32 PM

Change 961860 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Confirm SX with prefilled section: Redirect to platform-specific editor

https://gerrit.wikimedia.org/r/961860

gerritbot added a project: Patch-For-Review.Sep 28 2023, 5:32 PM
ngkountas mentioned this in T328936: Adjust confirmation step to redirect to the platform-specific translation editor.Sep 28 2023, 5:44 PM
ngkountas added a subtask: T328936: Adjust confirmation step to redirect to the platform-specific translation editor.
gerritbot added a comment.Sep 29 2023, 7:17 AM

Change 961860 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Confirm SX with prefilled section: Redirect to platform-specific editor

https://gerrit.wikimedia.org/r/961860

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2023, 7:30 AM
ngkountas moved this task from In Review to Check after deployment on the Language-Team (Language-2023-July-September) board.Sep 29 2023, 8:13 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.29; 2023-10-03); removed MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 29 2023, 10:01 AM
gerritbot added a comment.Sep 29 2023, 3:56 PM

Change 962059 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

gerritbot added a project: Patch-For-Review.Sep 29 2023, 3:56 PM
Pginer-WMF edited projects, added Language-Team (Language-2023-October-December); removed Language-Team (Language-2023-July-September).Oct 2 2023, 8:58 AM
Pginer-WMF moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-October-December) board.
gerritbot added a comment.Oct 2 2023, 2:37 PM

Change 962059 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230929

https://gerrit.wikimedia.org/r/962059

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 3:11 PM
ngkountas moved this task from Check after deployment to Needs QA on the Language-Team (Language-2023-October-December) board.Oct 5 2023, 3:45 PM
Pginer-WMF closed subtask T328936: Adjust confirmation step to redirect to the platform-specific translation editor as Resolved.Nov 21 2023, 12:00 PM
Pginer-WMF edited projects, added Language-Team (Language-2024-January-March); removed Language-Team (Language-2023-October-December).Jan 8 2024, 10:34 AM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2024-January-March) board.
ngkountas added a comment.Jan 8 2024, 7:42 PM

The issue has now been also fixed for the cases when the section is preselected through the section URL param, as demonstrated in the following screencast:

In the below screencast, one can see that the background color of the prefilled section banner doesn't match the design. This is fixed in this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/988710

ngkountas added a comment.Jan 8 2024, 7:43 PM

Following the above comment, I'm updating the task description to reflect the fix and I think we can close this task as done.

ngkountas updated the task description. (Show Details)Jan 8 2024, 7:43 PM
ngkountas moved this task from Needs QA to Done on the Language-Team (Language-2024-January-March) board.
Pginer-WMF closed this task as Resolved.Jan 19 2024, 9:39 AM
Pginer-WMF subscribed.

Great. Thanks for improving the consistency for the different workflows. In the screencasts I noticed a separate regression which I reported in T355398: Readability regression when a section is selected through the url

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits