Page MenuHomePhabricator

A warning dialog is being shown when creating a new temp account, while being logged out on another tab
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Create a temporary account.
  2. On a second tab clear the session.
  3. Go back to the first tab where it still shows you are using that temporary account (because you did not refresh the page and assuming there is nothing we can do about that).
  4. Try publishing an edit.

Current behavior: It shows a non-standard warning message that something went wrong and your edit will be associated with a new temp account if you continue.

Screenshot 2023-09-08 at 5.48.02 PM.png (1×2 px, 495 KB)

Suggested behavior:

a. Allow the user to publish without showing a warning message since a temporary account is going to be created anyway.
b. Show the standard message for warning that you see under Edit Notices "Warning: You are not logged in. Your input will be assigned to an automatically generated name by storing a cookie in your browser. Your IP address will be visible to trusted users. When you log in or create an account, your edits will be associated with a name you choose; this also has other advantages."

Screenshot 2023-09-08 at 9.31.49 PM.png (378×776 px, 75 KB)

Event Timeline

It looks like the behavior has changed since this ticket was opened. Currently, a message similar to the second suggestion is shown.

Screenshot 2024-08-02 at 5.23.40 PM.png (694×2 px, 141 KB)

@Amdrel Your screenshot is from the MediaWiki core wikitext editor, while @Ryasmeen's is from the VisualEditor. They might behave differently.

Ah, it seems you are correct. Switching to the VisualEditor results in the reported behavior.

Change #1062472 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/VisualEditor@master] Reattempt save when refreshing temporary user if session expired

https://gerrit.wikimedia.org/r/1062472

Change #1062472 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reattempt save when refreshing temporary user if session expired

https://gerrit.wikimedia.org/r/1062472

Change #1067435 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Reattempt save as temporary user only when we were previously anon

https://gerrit.wikimedia.org/r/1067435

Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning, and displaying as expected.

kostajh assigned this task to Amdrel.

Change #1067435 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Reattempt save as temporary user only when we were previously anon

https://gerrit.wikimedia.org/r/1067435