ChipInput: Add read-only state
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Catrope
	Sep 12 2023, 1:15 AM

Description

Background goal

NOTE: We will not implement this until we have clear real use cases to cover.

Split off from T337095, specifically:

In T337095#9151791, @bmartinezcalvo wrote:

Design sign-off done. I've found two things to fix:

Read-only state is missing

[...]

In T337095#9157734, @gerritbot wrote:

Change 956483 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] ChipInput: Implement read-only state

https://gerrit.wikimedia.org/r/956483

Open questions

In T337095#9158827, @Volker_E wrote:

Signifying readonly visually and then having ability to interact (remove) FilterChips is contradictory in my opinion and we should limit the readonly ChipInput to FilterChips without remove button only.

Proposal

We could implement the read-only state for the chip to make them non-interactive. This read-only state will not use the remove button within the chip.

Captura de pantalla 2023-09-13 a las 19.54.47.png (391×717 px, 29 KB)

Design spec

Add Figma spec sheet once it's done

Acceptance criteria

Design

Design the Figma spec sheet and add it in this task
Update component in the Figma library

Code

Implement the read-only state in the Codex ChipInput

Details

	Subject	Repo	Branch	Lines +/-
	ChipInput: Implement read-only state	design/codex	main	+74 -21

Customize query in gerrit

Related Objects

Mentioned In: T337095: ChipInput: Add ChipInput component to Codex
Mentioned Here: T337095: ChipInput: Add ChipInput component to Codex

Event Timeline

Catrope created this task.Sep 12 2023, 1:15 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptSep 12 2023, 1:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Catrope edited projects, added Design-System-Team (Design-Systems-Sprint-8); removed Design-System-Team.Sep 12 2023, 1:15 AM

Catrope moved this task from Committed to Code Review on the Design-System-Team (Design-Systems-Sprint-8) board.

Catrope mentioned this in T337095: ChipInput: Add ChipInput component to Codex.

Change 956483 had a related patch set uploaded (by Catrope; author: Anne Tomasevich):

[design/codex@main] ChipInput: Implement read-only state

https://gerrit.wikimedia.org/r/956483

gerritbot added a project: Patch-For-Review.Sep 12 2023, 1:16 AM

bmartinezcalvo updated the task description. (Show Details)Sep 13 2023, 2:50 PM

As decided during the last DST meeting, we will not implement this read-only state until we have clear real use cases to cover. So moving this task outside the sprint. cc: @CCiufo-WMF

CCiufo-WMF removed AnneT as the assignee of this task.Sep 13 2023, 9:26 PM

CCiufo-WMF moved this task from Inbox to Planned Component Updates on the Codex board.

CCiufo-WMF moved this task from Inbox to Backlog on the Design-System-Team board.

CCiufo-WMF added a subscriber: AnneT.

Change 956483 abandoned by Anne Tomasevich: