Page MenuHomePhabricator

Visual diff: jQuery.Deferred exception: char1.match is not a function
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Open https://de.wikipedia.org/w/index.php?title=Wikipedia%3ARedaktion_Informatik%2FArbeitslisten%2FTechnische_Informatik&diff=237285837&oldid=237227940&diffmode=visual

What happens?:

Visual diff loading fails with jQuery.Deferred exception: char1.match is not a function

Software version:
1.41.0-wmf.26

Tested on Windows/Firefox 117 with Vector-2022 and Vector skin.

Event Timeline

Change 972422 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Update diff-match-patch, removing cleanupSemanticLossless

https://gerrit.wikimedia.org/r/972422

Testing with diff_match_patch.prototype.diff_cleanupSemanticLossless = function() {} in the console, output looks reasonable again:

image.png (903×1 px, 341 KB)

Change 972422 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Update diff-match-patch, removing cleanupSemanticLossless

https://gerrit.wikimedia.org/r/972422

Change 972466 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

https://gerrit.wikimedia.org/r/972466

Change 972466 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

https://gerrit.wikimedia.org/r/972466

matmarex assigned this task to Esanders.
matmarex removed a project: Better-Diffs-2023.
matmarex subscribed.