Visual diff: jQuery.Deferred exception: char1.match is not a function
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	hgzh
	Sep 15 2023, 8:25 AM

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Visual diff loading fails with jQuery.Deferred exception: char1.match is not a function

Software version:
1.41.0-wmf.26

Tested on Windows/Firefox 117 with Vector-2022 and Vector skin.

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (df7099eab)	mediawiki/extensions/VisualEditor	master	+2 -1
	Update diff-match-patch, removing cleanupSemanticLossless	VisualEditor/VisualEditor	master	+4 -116

Change 972422 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Update diff-match-patch, removing cleanupSemanticLossless

Testing with diff_match_patch.prototype.diff_cleanupSemanticLossless = function() {} in the console, output looks reasonable again:

Change 972422 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Update diff-match-patch, removing cleanupSemanticLossless

Change 972466 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

Change 972466 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

matmarex closed this task as Resolved.Nov 7 2023, 9:06 PM

matmarex assigned this task to Esanders.

matmarex subscribed.

	F41466481: image.png
	Nov 7 2023, 4:55 PM