Page MenuHomePhabricator
Create Task
Maniphest T346685

Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo Extension
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
None
Authored By
KSarabia-WMF
Sep 18 2023, 7:18 PM
Tags
Referenced Files
F37854599: screenshot 34.mov.gif
Sep 29 2023, 9:08 PM
F37854593: screenshot 90.png
Sep 29 2023, 9:08 PM
F37748478: screenshot 30.mov.gif
Sep 22 2023, 2:06 AM
F37748476: screenshot.png
Sep 22 2023, 2:06 AM
F37740842: screenshot 22.mov.gif
Sep 20 2023, 1:38 AM
F37730769: Sep-18-2023 14-26-18.gif
Sep 18 2023, 7:27 PM
F37730756: Screenshot 2023-09-18 at 1.12.46 PM.png
Sep 18 2023, 7:18 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
KSarabia-WMF
Masumrezarock100
ovasileva

Description

NOTE: In Minerva desktop skin there is an existing bug relating to the tray icon (T343839). This is out of scope for the bug.

I am experiencing an issue with the Minerva skin and the Echo extension. When I click on the bell or tray icon, instead of the sliding drawer rendering as expected, it is redirecting me to the notification page. This behavior is not consistent with the intended functionality of the Echo extension.

Steps to Reproduce:

  1. Switch to mobile site (Minerva skin) e.g. https://en.m.wikipedia.beta.wmflabs.org/
  2. Ensure the Echo extension is enabled.
  3. Click on the bell icon in the user interface.

Expected Behavior:
Upon clicking the bell icon, a sliding drawer should appear on the right, displaying notifications.

Actual Behavior:
Clicking the bell icon redirects me to the notification page, and the sliding drawer does not render.

Sep-18-2023 14-26-18.gif (220×320 px, 61 KB)

Pixel Error

Screenshot 2023-09-18 at 1.12.46 PM.png (1×3 px, 280 KB)

QA Results - Beta

ACStatusDetails
1✅T346685#9189604

QA Results - Prod

ACStatusDetails
1✅T346685#9212445

Details

SubjectRepoBranchLines +/-
Fixes notification overlay: Change URL using locationmediawiki/skins/MinervaNeuemaster+1 -6
Customize query in gerrit

Related Objects

Event Timeline

KSarabia-WMF created this task.Sep 18 2023, 7:18 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptSep 18 2023, 7:18 PM
KSarabia-WMF triaged this task as Unbreak Now! priority.Sep 18 2023, 7:18 PM
KSarabia-WMF added a project: Web-Team-Backlog.
KSarabia-WMF moved this task from Incoming to Web Team FY2023-24 Q1 Sprint 6 on the Web-Team-Backlog board.
KSarabia-WMF edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog.
KSarabia-WMF updated the task description. (Show Details)
KSarabia-WMF updated the task description. (Show Details)
KSarabia-WMF updated the task description. (Show Details)Sep 18 2023, 7:27 PM
KSarabia-WMF added a parent task: T345888: 1.41.0-wmf.27 deployment blockers.Sep 18 2023, 7:50 PM
gerritbot added a comment.Sep 18 2023, 8:54 PM

Change 958570 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use checkRoute when using navigate

https://gerrit.wikimedia.org/r/958570

gerritbot added a project: Patch-For-Review.Sep 18 2023, 8:54 PM
Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 18 2023, 8:54 PM
gerritbot added a comment.Sep 18 2023, 9:33 PM

Change 958570 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes notification overlay: Change URL using location

https://gerrit.wikimedia.org/r/958570

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Sep 18 2023, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 18 2023, 10:10 PM
Jdlrobson assigned this task to Edtadros.Sep 18 2023, 10:13 PM
Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.
Jdlrobson removed a parent task: T345888: 1.41.0-wmf.27 deployment blockers.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Jdlrobson subscribed.

Edward, if this fails QA please change priority back to unbreak now :)

Aklapper added a project: MinervaNeue.Sep 19 2023, 4:56 AM
Jdlrobson set the point value for this task to 0.Sep 19 2023, 5:06 PM
Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Sep 19 2023, 11:25 PM
Edtadros raised the priority of this task from Medium to Unbreak Now!.Sep 20 2023, 1:38 AM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Steps to Reproduce:

Set to Minerva
Ensure the Echo extension is enabled.
Click on the bell or tray icon in the user interface.
Upon clicking the bell or tray icon, a sliding drawer should appear on the right, displaying notifications.

As best as I can tell this is on the desktop Minerva skin. That's the only way I get the tray icon. When in desktop a drawer doesn't open. When in mobile, I can only confirm that notifications opens up a drawer. See the desktop behavior below.

screenshot 22.mov.gif (822×1 px, 734 KB)

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.EditedSep 20 2023, 2:01 AM

That's an unrelated documented bug. Will share URL tomorrow with better QA steps (have confirmed mobile notification button works for me)

Jdlrobson updated the task description. (Show Details)Sep 20 2023, 4:28 PM
Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Edtadros removed Edtadros as the assignee of this task.Sep 22 2023, 2:06 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Switch to mobile site (Minerva skin) e.g. https://en.m.wikipedia.beta.wmflabs.org/
Ensure the Echo extension is enabled.

screenshot.png (852×1 px, 225 KB)

Click on the bell icon in the user interface.
✅ AC1: Upon clicking the bell icon, a sliding drawer should appear on the right, displaying notifications.
screenshot 30.mov.gif (850×1 px, 800 KB)

Edtadros updated the task description. (Show Details)Sep 22 2023, 2:07 AM
Jdlrobson assigned this task to ovasileva.Sep 22 2023, 10:56 PM
ovasileva moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Sep 25 2023, 3:10 PM

Looks good, moving to QA in Prod.

Jdlrobson reassigned this task from ovasileva to Edtadros.Sep 26 2023, 4:37 PM
Jdlrobson added a subscriber: ovasileva.
Edtadros closed this task as Resolved.Sep 29 2023, 9:08 PM
Edtadros removed Edtadros as the assignee of this task.
Edtadros added a project: Verified.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Switch to mobile site (Minerva skin) e.g. https://en.m.wikipedia.beta.wmflabs.org/
Ensure the Echo extension is enabled.

screenshot 90.png (929×1 px, 212 KB)

Click on the bell icon in the user interface.
✅ AC1: Upon clicking the bell icon, a sliding drawer should appear on the right, displaying notifications.
screenshot 34.mov.gif (930×1 px, 835 KB)

Edtadros updated the task description. (Show Details)Sep 29 2023, 9:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL