Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo Extension
Open, MediumPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	KSarabia-WMF
	Mon, Sep 18, 7:18 PM

Description

NOTE: In Minerva desktop skin there is an existing bug relating to the tray icon (T343839). This is out of scope for the bug.

I am experiencing an issue with the Minerva skin and the Echo extension. When I click on the bell or tray icon, instead of the sliding drawer rendering as expected, it is redirecting me to the notification page. This behavior is not consistent with the intended functionality of the Echo extension.

Steps to Reproduce:

Switch to mobile site (Minerva skin) e.g. https://en.m.wikipedia.beta.wmflabs.org/
Ensure the Echo extension is enabled.
Click on the bell icon in the user interface.

Expected Behavior:
Upon clicking the bell icon, a sliding drawer should appear on the right, displaying notifications.

Actual Behavior:
Clicking the bell icon redirects me to the notification page, and the sliding drawer does not render.

Sep-18-2023 14-26-18.gif (220×320 px, 61 KB)

Pixel Error

Screenshot 2023-09-18 at 1.12.46 PM.png (1×3 px, 280 KB)

QA Results - Beta

AC	Status	Details
1	✅	T346685#9189604

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MinervaNeue	master	+1 -6	Fixes notification overlay: Change URL using location

Customize query in gerrit

Related Objects

Mentioned In: T346851: Verify 1.41.0-wmf.30 deployment
Mentioned Here: T343839: Echo has been disabled in Minerva desktop. due to badge replacement issue

Event Timeline

KSarabia-WMF created this task.Mon, Sep 18, 7:18 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMon, Sep 18, 7:18 PM

KSarabia-WMF triaged this task as Unbreak Now! priority.Mon, Sep 18, 7:18 PM

KSarabia-WMF added a project: Web-Team-Backlog.

KSarabia-WMF moved this task from Incoming to Web Team FY2023-24 Q1 Sprint 6 on the Web-Team-Backlog board.

KSarabia-WMF edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6); removed Web-Team-Backlog.

KSarabia-WMF updated the task description. (Show Details)

KSarabia-WMF updated the task description. (Show Details)Mon, Sep 18, 7:27 PM

KSarabia-WMF added a parent task: T345888: 1.41.0-wmf.27 deployment blockers.Mon, Sep 18, 7:50 PM

Change 958570 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use checkRoute when using navigate

https://gerrit.wikimedia.org/r/958570

gerritbot added a project: Patch-For-Review.Mon, Sep 18, 8:54 PM

Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.Mon, Sep 18, 8:54 PM

Change 958570 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fixes notification overlay: Change URL using location

https://gerrit.wikimedia.org/r/958570

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.27; 2023-09-19).Mon, Sep 18, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mon, Sep 18, 10:10 PM

Edward, if this fails QA please change priority back to unbreak now :)

Aklapper added a project: MinervaNeue.Tue, Sep 19, 4:56 AM

Jdlrobson set the point value for this task to 0.Tue, Sep 19, 5:06 PM

Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Tue, Sep 19, 11:25 PM

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Steps to Reproduce:

Set to Minerva
Ensure the Echo extension is enabled.
Click on the bell or tray icon in the user interface.
Upon clicking the bell or tray icon, a sliding drawer should appear on the right, displaying notifications.

As best as I can tell this is on the desktop Minerva skin. That's the only way I get the tray icon. When in desktop a drawer doesn't open. When in mobile, I can only confirm that notifications opens up a drawer. See the desktop behavior below.

screenshot 22.mov.gif (822×1 px, 734 KB)

That's an unrelated documented bug. Will share URL tomorrow with better QA steps (have confirmed mobile notification button works for me)

Jdlrobson updated the task description. (Show Details)Wed, Sep 20, 4:28 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Switch to mobile site (Minerva skin) e.g. https://en.m.wikipedia.beta.wmflabs.org/
Ensure the Echo extension is enabled.

Click on the bell icon in the user interface.
✅ AC1: Upon clicking the bell icon, a sliding drawer should appear on the right, displaying notifications.

screenshot 30.mov.gif (850×1 px, 800 KB)

Edtadros updated the task description. (Show Details)Fri, Sep 22, 2:07 AM

Jdlrobson assigned this task to ovasileva.Fri, Sep 22, 10:56 PM

Looks good, moving to QA in Prod.

Jdlrobson reassigned this task from ovasileva to Edtadros.Tue, Sep 26, 4:37 PM

Jdlrobson added a subscriber: ovasileva.

	F37730756: Screenshot 2023-09-18 at 1.12.46 PM.png
	Mon, Sep 18, 7:18 PM

	F37748476: screenshot.png
	Fri, Sep 22, 2:06 AM

Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo ExtensionOpen, MediumPublic0 Estimated Story PointsActions

Description

QA Results - Beta

Details

Related Objects

Event Timeline

Test Result - Beta

QA Steps

Test Result - Beta

QA Steps

Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo Extension
Open, MediumPublic0 Estimated Story Points
Actions