Page MenuHomePhabricator
Create Task
Maniphest T345888

1.41.0-wmf.27 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
jnuche
Release Version
1.41.0-wmf.27
Release Date
Sep 18 2023, 12:00 AM

2023 week 38 1.41-wmf.27 Changes wmf/1.41.0-wmf.27

This MediaWiki Train Deployment is scheduled for the week of Monday, September 18th:

Monday September 18thTuesday, September 19thWednesday, September 20thThursday, September 21stFriday
Backports only.Branch wmf.27 and deploy to Group 0 Wikis.Deploy wmf.27 to Group 1 Wikis.Deploy wmf.27 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.27 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.41.0-wmf.26
Next: 1.41.0-wmf.28
SubjectRepoBranchLines +/-
group2 wikis to 1.41.0-wmf.27operations/mediawiki-configmaster+329 -329
group1 wikis to 1.41.0-wmf.27operations/mediawiki-configmaster+548 -548
group0 wikis to 1.41.0-wmf.27operations/mediawiki-configmaster+132 -132
testwikis wikis to 1.41.0-wmf.27operations/mediawiki-configmaster+4 -4
Branch commit for wmf/1.41.0-wmf.27mediawiki/corewmf/1.41.0-wmf.27+996 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Sep 7 2023, 10:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2023, 10:51 PM
thcipriani assigned this task to brennen.Sep 7 2023, 10:53 PM
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: jnuche.
thcipriani set the point value for this task to 5.
thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
brennen added a project: User-brennen.Sep 11 2023, 6:30 PM
brennen moved this task from Backlog to Next on the User-brennen board.
Lucas_Werkmeister_WMDE subscribed.Sep 15 2023, 4:18 PM

We’re repeating the hard deprecation that had to be reverted in the previous train, since the caller that caused so many deprecation warnings last time should be fixed now. If you see any wfDeprecated() warnings regarding serialize() or unserialize() methods (specifically, on the Wikibase-related classes ItemId, NumericPropertyId, FederatedPropertyId, LexemeId, FormId, SenseId, or MediaInfoId), feel free to bring it up at T345856 and/or directly revert change 957772. (Also FYI, I will be almost totally offline on Monday and Tuesday, don’t wait for me if you want to revert on those days ^^)

Michael subscribed.Sep 18 2023, 8:04 AM
KSarabia-WMF added a subtask: T346685: Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo Extension.Sep 18 2023, 7:50 PM
Jdlrobson removed a subtask: T346685: Sliding Drawer Not Rendering When Clicking Bell/Tray Icon - Minerva - Echo Extension.Sep 18 2023, 10:13 PM
gerritbot added a comment.Sep 19 2023, 2:06 AM

Change 957819 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.41.0-wmf.27] Branch commit for wmf/1.41.0-wmf.27

https://gerrit.wikimedia.org/r/957819

gerritbot added a project: Patch-For-Review.Sep 19 2023, 2:06 AM
gerritbot added a comment.Sep 19 2023, 2:20 AM

Change 957819 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.27] Branch commit for wmf/1.41.0-wmf.27

https://gerrit.wikimedia.org/r/957819

gerritbot added a comment.Sep 19 2023, 3:01 AM

Change 958595 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/958595

gerritbot added a comment.Sep 19 2023, 3:02 AM

Change 958595 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/958595

Stashbot added a comment.Sep 19 2023, 3:02 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-19T03:02:43Z] <mwpresync@deploy1002> Started scap: testwikis wikis to 1.41.0-wmf.27 refs T345888

Stashbot added a comment.Sep 19 2023, 4:03 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-19T04:03:49Z] <mwpresync@deploy1002> Finished scap: testwikis wikis to 1.41.0-wmf.27 refs T345888 (duration: 61m 05s)

Clement_Goubert added a subtask: T346800: startupregistrystats-testwiki periodic job fails.Sep 19 2023, 4:34 PM
Ladsgroup subscribed.Sep 19 2023, 4:38 PM
brennen moved this task from Next to Doing on the User-brennen board.Sep 19 2023, 5:03 PM
Jdlrobson added a subtask: T342277: Minerva font size setting should use new client side preferences.Sep 19 2023, 6:40 PM
Jdlrobson subscribed.Sep 19 2023, 6:56 PM

As written T342277 will introduce production errors if rolled out with the train. We're working on a fix.

Jdlrobson added a subtask: T345363: Create font size settings interface functionality for vector.Sep 19 2023, 7:21 PM
brennen added a comment.Sep 19 2023, 7:57 PM

As written T342277 will introduce production errors if rolled out with the train. We're working on a fix.

Give me a shout when fixes are in / there's a patch I should deploy.

matmarex closed subtask T346800: startupregistrystats-testwiki periodic job fails as Resolved.Sep 19 2023, 9:00 PM
Stashbot added a comment.Sep 19 2023, 9:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-19T21:41:13Z] <brennen> train 1.41.0-wmf.27 (T345888): blockers resolved; rolling to group0

gerritbot added a comment.Sep 19 2023, 9:41 PM

Change 959058 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959058

gerritbot added a comment.Sep 19 2023, 9:43 PM

Change 959058 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959058

Stashbot added a comment.Sep 19 2023, 9:50 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-19T21:50:35Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group0 wikis to 1.41.0-wmf.27 refs T345888

Jdlrobson mentioned this in T346851: Verify 1.41.0-wmf.30 deployment.Sep 19 2023, 11:22 PM
Stashbot added a comment.Sep 20 2023, 6:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T18:02:18Z] <brennen> train 1.41.0-wmf.27 (T345888): no current blockers, logs clean, rolling to group1

brennen removed a subtask: T345363: Create font size settings interface functionality for vector.Sep 20 2023, 6:04 PM
brennen removed a subtask: T342277: Minerva font size setting should use new client side preferences.
gerritbot added a comment.Sep 20 2023, 6:06 PM

Change 959329 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959329

gerritbot added a comment.Sep 20 2023, 6:07 PM

Change 959329 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959329

Stashbot added a comment.Sep 20 2023, 6:14 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T18:14:34Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group1 wikis to 1.41.0-wmf.27 refs T345888

Stashbot added a comment.Sep 20 2023, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T18:21:53Z] <brennen@deploy2002> Synchronized php: group1 wikis to 1.41.0-wmf.27 refs T345888 (duration: 07m 17s)

ihurbain added subtasks: T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php), T347009: PHP Notice: Undefined index: OutputHooks.Sep 21 2023, 9:02 AM
ihurbain subscribed.

Just added two blockers for time to have another opinion on them before deploying them to group2. I'm probably overly careful, but I'm worried about cache incompatibility on T347009 and about logspam (and possibly rendering issues) on T347007.

ihurbain removed a subtask: T347007: TypeError: substr() expects parameter 2 to be int, null given (via Parsoid TableFixups.php).Sep 21 2023, 9:17 AM

Removing https://phabricator.wikimedia.org/T347007 from blockers since it's on dewiki, it's not train-blocking.

ihurbain closed subtask T347009: PHP Notice: Undefined index: OutputHooks as Resolved.Sep 21 2023, 9:33 AM

T347009 is closed as a deployment side effect issue. The same issue and the associated warnings are probably to be expected during group2 deployment.

brennen added a subtask: T347074: LogicException: RequestContext should not be cloned, use DerivativeContext instead..Sep 21 2023, 3:22 PM
brennen mentioned this in T255706: [WB-Client] [TECH] Wikibase\Client\Usage\Sql\EntityUsageTable::addUsages Deadlock.Sep 21 2023, 3:28 PM
brennen mentioned this in T347078: InvalidArgumentException: Wikimedia\Rdbms\Platform\SQLPlatform::makeList: empty input for field page_namespace.Sep 21 2023, 3:31 PM
brennen mentioned this in T347083: UploadStashFileNotFoundException: Key "[key]" not found in stash..Sep 21 2023, 3:46 PM
brennen mentioned this in T312605: Duplicate entry for key 'cx_translation_ref' in ContentTranslation\Translation::createQuery.Sep 21 2023, 3:55 PM
Stashbot added a comment.Sep 21 2023, 6:05 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-21T18:05:21Z] <brennen> train 1.41.0-wmf.27 (T345888): no current blockers, logs clean, rolling to group2 shortly.

gerritbot added a comment.Sep 21 2023, 6:06 PM

Change 959833 had a related patch set uploaded (by TrainBranchBot; author: Brennen Bearnes):

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959833

gerritbot added a comment.Sep 21 2023, 6:07 PM

Change 959833 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 wikis to 1.41.0-wmf.27

https://gerrit.wikimedia.org/r/959833

Stashbot added a comment.Sep 21 2023, 6:15 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-21T18:15:07Z] <brennen@deploy2002> rebuilt and synchronized wikiversions files: group2 wikis to 1.41.0-wmf.27 refs T345888

thcipriani closed this task as Resolved.Sep 22 2023, 5:55 PM
brennen moved this task from Doing to Done or Declined on the User-brennen board.Oct 17 2023, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits