Tab order is broken for Page Quality widget
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Samwilson
	Oct 8 2023, 12:41 AM

Description

Steps to replicate the issue (include links if applicable):

Edit any Page-namespace page on Wikisource, e.g. https://en.wikisource.org/w/index.php?title=Page:Papers_of_William_Shakespeare_Hall,_1861%E2%80%931895.pdf/77&action=edit
Focus the edit summary field
Try to tab to the page-quality radio buttons

What happens?:

The radio buttons are bypassed.

What should have happened instead?:

The radio buttons should be focussed and be able to be selected with left/right arrow keys.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Reported at https://en.wikisource.org/wiki/Wikisource:Scriptorium/Help#Can%E2%80%99t_mark_pages_as_proofread

QA Results - En Wikisource PROD

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T348389 here

Details

	Subject	Repo	Branch	Lines +/-
	Page quality widget: fix tabindex typo and increment	mediawiki/extensions/ProofreadPage	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T344928 Page status changes not captured/saved by Edit recovery
		Resolved	BUG REPORT	Samwilson	T348389 Tab order is broken for Page Quality widget

Event Timeline

Samwilson created this task.Oct 8 2023, 12:41 AM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptOct 8 2023, 12:41 AM

Samwilson removed a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 8 2023, 12:42 AM

Samwilson mentioned this in T348382: Quality radio button state not kept when using preview.Oct 8 2023, 12:48 AM

Change 964173 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Page quality widget: fix tabindex typo and increment

https://gerrit.wikimedia.org/r/964173

gerritbot added a project: Patch-For-Review.Oct 8 2023, 1:32 AM

Samwilson claimed this task.Oct 8 2023, 1:32 AM

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.

Change 964173 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Page quality widget: fix tabindex typo and increment

https://gerrit.wikimedia.org/r/964173

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 8 2023, 4:00 PM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Oct 10 2023, 9:04 PM

Samwilson moved this task from Backlog to Ready on the Edit Recovery board.Oct 11 2023, 10:45 AM

@Samwilson From the edit summary field, you are able to tab to the radio buttons and select between each one with the left/right arrow keys as seen in the gif. I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Wiksource Patch MW-1.41-notes (1.41.0-wmf.30; 2023-10-10) Group 1
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 118, Safari 17.0
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikisource.org/w/index.php?title=Page:Papers_of_William_Shakespeare_Hall,_1861%E2%80%931895.pdf/77&action=edit