Remove hard dependency on DiscussionTools from ReportIncident
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Oct 11 2023, 11:15 AM

Description

Currently the DiscussionTools extension has to be installed for the ReportIncident extension to work. This is because the Hooks.php file implements a DiscussionTools hook and as such when the DiscussionTools extension is not installed this fails to work.

Acceptance criteria

The DiscussionTools hook usage should be moved to a separate handler
Tests related to DiscussionTools be skipped if not installed.
The extension be tested to work without DiscussionTools enabled

Details

	Subject	Repo	Branch	Lines +/-
	Remove hard dependency on DiscussionTools	mediawiki/extensions/ReportIncident	master	+829 -622

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T337566 [EPIC]: Incident Reporting System - Minimal Testable Product (MTP)
		Resolved		Dreamy_Jazz	T348630 Remove hard dependency on DiscussionTools from ReportIncident

Event Timeline

Dreamy_Jazz created this task.Oct 11 2023, 11:15 AM

Restricted Application added a project: Trust and Safety Tools Team Backlog. · View Herald TranscriptOct 11 2023, 11:15 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh added a parent task: T337566: [EPIC]: Incident Reporting System - Minimal Testable Product (MTP).Oct 11 2023, 11:19 AM

Change 965111 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ReportIncident@master] Remove hard dependency on DiscussionTools

https://gerrit.wikimedia.org/r/965111

gerritbot added a project: Patch-For-Review.Oct 11 2023, 11:49 AM

Dreamy_Jazz edited projects, added Trust and Safety Tools Team Backlog (Kanban); removed Trust and Safety Tools Team Backlog.Oct 11 2023, 11:50 AM

Dreamy_Jazz moved this task from 🎬 Ready to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.

Change 965111 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Remove hard dependency on DiscussionTools

https://gerrit.wikimedia.org/r/965111

kostajh mentioned this in rEREI6fd825d36040: Remove hard dependency on DiscussionTools.Oct 13 2023, 7:54 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2023, 8:10 AM

Suggested QA steps (can be performed on PatchDemo or local wikis):

Install ReportIncident extension
Make sure the DiscussionTools extension is not installed and uninstall it if needed.
Load a user talk page
Verification step 1: Verify that the user talk page loads successfully.
Verification step 2: Verify that a "Report" link appears in the "Tools" menu
Click on the "Report" link
Verification step 3: Verify that the reporting dialog is shown

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/09072d0263/w

Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/09072d0263/w/~~

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/5a294b3931/w

I have verified that without DiscussionTools extension installed the Report Incident still functions and displays as expected (per the instructions listed in the QA Steps) and (Acceptance Criteria listed in the ticket Description).
Great Work! @Dreamy_Jazz, and as always Thank You for the QA Steps!!!
Testing was performed at the following url:
https://patchdemo.wmflabs.org/wikis/5a294b3931/w/index.php?title=User_talk:Patch_Demo&action=edit&redlink=1

kostajh closed this task as Resolved.Oct 19 2023, 6:00 AM

Dreamy_Jazz updated the task description. (Show Details)Oct 30 2023, 10:47 AM