Page MenuHomePhabricator
Create Task
Maniphest T348741

Codex: Display warning about file title in form instead of extra page
Open, Needs TriagePublic
Actions

Assigned To
lilients_WMDE
Authored By
lilients_WMDE
Oct 12 2023, 11:55 AM
Tags
Referenced Files
F40300219: Screenshot from 2023-10-26 10-56-15.png
Oct 26 2023, 8:57 AM
F39851014: Peek 2023-10-24 16-46.gif
Oct 24 2023, 2:47 PM
F38816905: Peek 2023-10-19 15-57.gif
Oct 19 2023, 1:59 PM
F38215542: Screenshot from 2023-10-12 13-51-13.png
Oct 12 2023, 11:55 AM
Subscribers
Aklapper
lilients_WMDE
thiemowmde

Description

We want to display the warning about unmatching characters in the file title in the form with Codex instead of opening a new page (see screenshot).

Screenshot from 2023-10-12 13-51-13.png (377×902 px, 28 KB)

Outcome

Screenshot from 2023-10-26 10-56-15.png (374×1 px, 104 KB)

Screencast (click to view):

Peek 2023-10-24 16-46.gif (717×1 px, 1 MB)

Details

SubjectRepoBranchLines +/-
Codex: Fix title warning for titles with a blank spacemediawiki/extensions/FileImportermaster+2 -1
Avoid growing the button when the field growsmediawiki/extensions/FileImportermaster+8 -6
Codex: Display warning about file title in form instead of extra pagemediawiki/extensions/FileImportermaster+37 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilients_WMDE created this task.Oct 12 2023, 11:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2023, 11:55 AM
lilients_WMDE claimed this task.Oct 13 2023, 11:46 AM
lilients_WMDE moved this task from Backlog to Doing on the WMDE-TechWish-Maintenance-2023 board.
lilients_WMDE added a project: Move-Files-To-Commons.Oct 13 2023, 1:04 PM
lilients_WMDE updated the task description. (Show Details)Oct 13 2023, 3:32 PM
gerritbot added a comment.Oct 13 2023, 3:34 PM

Change 965769 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/FileImporter@master] [WIP] Display warning about file title in form instead of extra page

https://gerrit.wikimedia.org/r/965769

gerritbot added a project: Patch-For-Review.Oct 13 2023, 3:34 PM
lilients_WMDE updated the task description. (Show Details)Oct 19 2023, 1:59 PM
lilients_WMDE moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.
lilients_WMDE updated the task description. (Show Details)Oct 24 2023, 2:47 PM
thiemowmde subscribed.Oct 25 2023, 9:24 AM

Only one remark: I find it quite surprising to see the height of the button change. That shouldn't happen. But this is for a later, proper redesign by the WMDE-Design team. As this is all hidden behind a feature flag anyway it's totally fine to merge it as this for the moment.

lilients_WMDE updated the task description. (Show Details)Oct 26 2023, 8:57 AM
lilients_WMDE added a comment.Oct 26 2023, 1:40 PM

Agreed, that is actually strange. I also did not find any examples in the codex specification where there is an input field with a button next to it (neither in the TextInput nor in the Field ). Maybe we can ask someone from the design team, if we missed something or if the docu could be improved?

WMDE-Fisch moved this task from Review to Done on the WMDE-TechWish-Maintenance-2023 board.Oct 27 2023, 1:45 PM
gerritbot added a comment.Oct 27 2023, 2:09 PM

Change 965769 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: Display warning about file title in form instead of extra page

https://gerrit.wikimedia.org/r/965769

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2023, 2:10 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 27 2023, 3:00 PM
WMDE-Fisch renamed this task from Display warning about file title in form instead of extra page to Code: Display warning about file title in form instead of extra page.Oct 30 2023, 9:36 AM
WMDE-Fisch renamed this task from Code: Display warning about file title in form instead of extra page to Codex: Display warning about file title in form instead of extra page.
WMDE-Fisch moved this task from Backlog to Tickets in sprint on the Move-Files-To-Commons board.
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2023-11-22.Nov 22 2023, 7:14 AM
Tobi_WMDE_SW moved this task from Sprint Backlog to Demo on the WMDE-TechWish-Sprint-2023-11-22 board.Nov 22 2023, 7:16 AM
gerritbot added a comment.Nov 28 2023, 9:48 AM

Change 978003 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/FileImporter@master] Avoid growing the button when the field grows

https://gerrit.wikimedia.org/r/978003

gerritbot added a project: Patch-For-Review.Nov 28 2023, 9:48 AM
gerritbot added a comment.Nov 28 2023, 3:24 PM

Change 978003 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Avoid growing the button when the field grows

https://gerrit.wikimedia.org/r/978003

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2023, 3:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Nov 28 2023, 4:00 PM
awight moved this task from Demo to Tech Review on the WMDE-TechWish-Sprint-2023-11-22 board.Dec 5 2023, 9:01 AM
lilients_WMDE added a comment.EditedDec 5 2023, 2:34 PM

In sprint demo we noticed that the warning is not working for titles that have a space in the name. Example

lilients_WMDE moved this task from Tech Review to Doing on the WMDE-TechWish-Sprint-2023-11-22 board.Dec 5 2023, 3:05 PM
gerritbot added a comment.Dec 5 2023, 3:17 PM

Change 980415 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/FileImporter@master] Codex: Fix title warning for titles with a blank space

https://gerrit.wikimedia.org/r/980415

gerritbot added a project: Patch-For-Review.Dec 5 2023, 3:17 PM
lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-11-22 board.Dec 5 2023, 3:50 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2023-12-06.Dec 6 2023, 12:09 PM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-12-06 board.Dec 6 2023, 12:11 PM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-12-06 board.Dec 12 2023, 2:33 PM
gerritbot added a comment.Dec 12 2023, 4:23 PM

Change 980415 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Codex: Fix title warning for titles with a blank space

https://gerrit.wikimedia.org/r/980415

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2023, 4:30 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 12 2023, 5:00 PM
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2023-12-06 board.Dec 20 2023, 9:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits