Page MenuHomePhabricator
Create Task
Maniphest T348807

Deprecate mw.mobileFrontend public facing library
Closed, ResolvedPublicBUG REPORT
Actions

Description

NOTE: Please feel free to create a subtask and untag your components to fit into your own team process.

Impacted code paths: https://codesearch.wmcloud.org/search/?q=mw.mobileFrontend&files=&excludeFiles=&repos=

Follow up from T348081

The mw.mobileFrontend library predates ResourceLoader package files and should be removed in favor of the latter.

Since MobileFrontend was built many of its APIs are no longer relevant. For example:

  • We're moving to Codex and using Codex markup is preferable these days.
  • ES6 is now the normal. Code such as mw.mobileFrontend.require( 'util' ).mfExtend can be replaced with native ES6
  • Hooks are a stable contract and are better suited than the EventEmitter singleton.

Migration notes

Was usingUse this instead
mw.mobileFrontend.require( 'mobile.startup').Buttonrequire( 'mobile.startup').View and Codex markup where needed.
mw.mobileFrontend.require( 'mobile.startup').Iconrequire( 'mobile.startup').View and Codex markup where needed.
mw.mobileFrontend.require( 'mobile.startup').IconButtonrequire( 'mobile.startup').View and Codex markup where needed.
mw.mobileFrontend.require( 'mobile.startup').AnchorUse https://doc.wikimedia.org/codex/latest/components/mixins/link.html.
mw.mobileFrontend.require( 'mobile.startup' ).Skin.getSingleton().getLicenseMsg();require( 'mobile.startup').license()
mw.mobileFrontend.require( 'mobile.startup' ).lazyImagesrequire( 'mobile.startup').loadAllImagesInPage()
mw.mobileFrontend.require( 'mobile.startup' ).promisedViewrequire( 'mobile.startup').promisedView
mw.mobileFrontend.require( 'mobile.startup' ).Viewrequire( 'mobile.startup').View
mw.mobileFrontend.require( 'mobile.startup' ).OverlayManager.getSingleton()require( 'mobile.startup').getOverlayManager()
mw.mobileFrontend.require( 'mobile.startup' ).Drawerrequire( 'mobile.startup').Drawer
mw.mobileFrontend.require( 'mobile.startup' ).headers.headerrequire( 'mobile.startup').overlayHeader
mw.mobileFrontend.require( 'mobile.startup' ).Overlayrequire( 'mobile.startup').Overlay
mw.mobileFrontend.require( 'mobile.startup' ).eventBusSingleton.on( 'section-toggled'mw.hook( 'mobileFrontend.section-toggled' ).add
mw.mobileFrontend.require( 'mobile.startup' ).Browsernavigation.userAgent
mw.mobileFrontend.require( 'mobile.startup' ).util.parseHTMLUse $()

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedBUG REPORTNoneT348807 Deprecate mw.mobileFrontend public facing library
 InvalidNoneT350668 Deprecate mw.mobileFrontend

Event Timeline

Jdlrobson created this task.Oct 12 2023, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2023, 9:24 PM
Jdlrobson updated the task description. (Show Details)Oct 12 2023, 9:33 PM
Jdlrobson moved this task from Backlog to deprecations/removals/code simplification on the Web-Team-Backlog (Needs Prioritization (Tech)) board.Oct 17 2023, 3:14 PM
Jdlrobson mentioned this in T348081: Web team: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0.Oct 17 2023, 4:39 PM
gerritbot added a comment.Oct 18 2023, 7:08 PM

Change 966586 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] WIP: Drop mw.mobileFrontend references

https://gerrit.wikimedia.org/r/966586

gerritbot added a project: Patch-For-Review.Oct 18 2023, 7:08 PM
gerritbot added a comment.Nov 1 2023, 3:45 PM

Change 966586 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Drop mw.mobileFrontend references

https://gerrit.wikimedia.org/r/966586

Maintenance_bot removed a project: Patch-For-Review.Nov 1 2023, 4:10 PM
Jdlrobson added projects: Notifications, GrowthExperiments, ExternalGuidance, Maps (Kartographer), Thanks, VisualEditor.Nov 2 2023, 11:04 PM
Jdlrobson updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 2 2023, 11:04 PM
hueitan added a project: Wikistories.Nov 7 2023, 9:07 AM
Jdlrobson closed subtask T350668: Deprecate mw.mobileFrontend as Resolved.Nov 7 2023, 4:00 PM
Jdlrobson removed a project: Wikistories.
gerritbot added a comment.Nov 7 2023, 4:35 PM

Change 972417 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] ImageCarousel: Use eventBus global rather than parameter

https://gerrit.wikimedia.org/r/972417

gerritbot added a project: Patch-For-Review.Nov 7 2023, 4:35 PM
Aklapper changed the status of subtask T350668: Deprecate mw.mobileFrontend from Resolved to Invalid.Nov 7 2023, 4:37 PM
gerritbot added a comment.Nov 7 2023, 5:00 PM

Change 972259 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Drop mw.mobileFrontend references

https://gerrit.wikimedia.org/r/972259

gerritbot added a comment.Nov 13 2023, 5:50 PM

Change 972259 merged by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Drop mw.mobileFrontend references

https://gerrit.wikimedia.org/r/972259

gerritbot added a comment.Nov 13 2023, 7:41 PM

Change 972417 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] ImageCarousel: Use eventBus global rather than parameter

https://gerrit.wikimedia.org/r/972417

Maintenance_bot removed a project: Patch-For-Review.Nov 13 2023, 8:10 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 13 2023, 9:00 PM
Jdlrobson updated the task description. (Show Details)Nov 14 2023, 6:18 PM
gerritbot added a comment.Nov 14 2023, 6:22 PM

Change 974247 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Echo@master] Fix deprecated code paths

https://gerrit.wikimedia.org/r/974247

gerritbot added a project: Patch-For-Review.Nov 14 2023, 6:22 PM
Jdlrobson updated the task description. (Show Details)Nov 14 2023, 6:23 PM
gerritbot added a comment.Nov 14 2023, 6:24 PM

Change 974249 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Remove eslint disable in MobileFrontend

https://gerrit.wikimedia.org/r/974249

gerritbot added a comment.Nov 14 2023, 6:26 PM

Change 974250 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Kartographer@master] Use of mw.mobileFrontend is deprecated and unstable

https://gerrit.wikimedia.org/r/974250

gerritbot added a comment.Nov 15 2023, 12:06 AM

Change 974249 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Remove eslint disable in MobileFrontend

https://gerrit.wikimedia.org/r/974249

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.7; 2023-11-28); removed MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 15 2023, 1:00 AM
gerritbot added a comment.Nov 27 2023, 12:58 PM

Change 974247 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Fix deprecated code paths

https://gerrit.wikimedia.org/r/974247

gerritbot added a comment.Dec 1 2023, 12:15 AM

Change 979182 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Thanks@master] Do not use deprecated MobileFrontend library, use Codex

https://gerrit.wikimedia.org/r/979182

PatchDemoBot added a comment.Dec 1 2023, 12:22 AM

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0f15811000/w

gerritbot added a comment.Dec 1 2023, 10:15 AM

Change 974250 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use of mw.mobileFrontend is deprecated and unstable

https://gerrit.wikimedia.org/r/974250

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.9; 2023-12-12); removed MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Dec 1 2023, 11:00 AM
gerritbot added a comment.Dec 1 2023, 5:50 PM

Change 979402 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] mw.mobileFrontend is deprecated

https://gerrit.wikimedia.org/r/979402

gerritbot added a comment.Dec 1 2023, 6:19 PM

Change 979404 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ExternalGuidance@master] Do not use deprecated MobileFrontend libraries

https://gerrit.wikimedia.org/r/979404

Jdlrobson updated the task description. (Show Details)Dec 1 2023, 11:07 PM
Jdlrobson mentioned this in T352582: No icon on mobile growth home page overlay.Dec 2 2023, 12:10 AM
gerritbot added a comment.Dec 2 2023, 12:16 AM

Change 979431 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] Fixes overlay exit button and deprecation warnings

https://gerrit.wikimedia.org/r/979431

gerritbot added a comment.Dec 6 2023, 5:03 PM

Change 980910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/WikimediaEvents@master] MobileDiff: Module is incorrectly logging thanks button

https://gerrit.wikimedia.org/r/980910

gerritbot added a comment.Dec 12 2023, 5:45 PM

Change 979182 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] Do not use deprecated MobileFrontend library, use Codex

https://gerrit.wikimedia.org/r/979182

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.10; 2023-12-19); removed MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 12 2023, 7:01 PM
Jdlrobson removed a project: Thanks.Dec 12 2023, 7:02 PM
Jdlrobson triaged this task as High priority.Dec 14 2023, 12:22 AM
Jdlrobson lowered the priority of this task from High to Medium.
gerritbot added a comment.Dec 15 2023, 6:11 PM

Change 979404 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] Do not use deprecated MobileFrontend libraries

https://gerrit.wikimedia.org/r/979404

Jdlrobson removed projects: Maps (Kartographer), ExternalGuidance, Notifications.Dec 15 2023, 6:49 PM
Jdlrobson added subscribers: Urbanecm, Esanders.

The last two remaining patches are for GrowthExperiments and VisualEditors https://gerrit.wikimedia.org/r/979431 and https://gerrit.wikimedia.org/r/979402
@Esanders and @Urbanecm could you help me get this over the finish line? Thanks in advance.

gerritbot added a comment.Dec 19 2023, 12:04 PM

Change 979431 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Fix exit button and address deprecation warnings

https://gerrit.wikimedia.org/r/979431

Jdlrobson edited projects, added Editing-team; removed Growth-Team, GrowthExperiments, Web-Team-Backlog (Needs Prioritization (Tech)).Dec 19 2023, 4:09 PM
gerritbot added a comment.Jan 3 2024, 6:33 PM

Change 987459 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Drop the mw.mobileFrontend object

https://gerrit.wikimedia.org/r/987459

Jdlrobson renamed this task from Deprecate mw.mobileFrontend to Deprecate mw.mobileFrontend public facing library.Jan 3 2024, 6:34 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 3 on the Web-Team-Backlog board.Jan 4 2024, 5:53 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3); removed Web-Team-Backlog.
Jdlrobson added a project: Verified.Jan 4 2024, 9:51 PM
gerritbot added a comment.Jan 29 2024, 9:31 PM

Change 979402 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Dialogs: Avoid using the deprecated mw.mobileFrontend function

https://gerrit.wikimedia.org/r/979402

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Jan 29 2024, 10:00 PM
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 1 2024, 7:23 PM
Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.Feb 1 2024, 7:25 PM
Jdlrobson moved this task from FY2023-24 Q3 Sprint 3 to FY2023-24 Q3 Sprint 4 on the Web-Team-Backlog board.Feb 12 2024, 7:04 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 3).
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).Feb 26 2024, 7:04 PM
gerritbot added a comment.Mar 4 2024, 8:23 PM

Change 987459 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Drop the mw.mobileFrontend object

https://gerrit.wikimedia.org/r/987459

Jdlrobson closed this task as Resolved.Mar 4 2024, 8:54 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog (FY2023-24 Q3 Sprint 5).
Jdlrobson moved this task from Incoming to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Mar 4 2024, 10:00 PM
PatchDemoBot added a comment.Tue, Apr 23, 4:33 PM

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/0f15811000/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL