Page MenuHomePhabricator
Create Task
Maniphest T349048

Mark as reviewed log entry should mention if it's an article or redirect
Closed, ResolvedPublicFeature
Actions

Description

Feature summary (what you would like to be able to do and where):
Change log entry
Hey man im josh (talk | contribs | block) marked Columbia 'Coco' Diaz as reviewed
to
Hey man im josh (talk | contribs | block) marked the redirect Columbia 'Coco' Diaz as reviewed
or
Hey man im josh (talk | contribs | block) marked the article Columbia 'Coco' Diaz as reviewed

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

  • If a page gets moved or BLAR'd, it becomes difficult to see who marked the page as reviewed. The original title will get marked as reviewed at least twice, and one of those reviews will be for the redirect, not the article.
  • Example of a confusing log:

image.png (834×1 px, 202 KB)

Benefits (why should this be implemented?):

Details

SubjectRepoBranchLines +/-
Differentiate between redirects and articles in review logs going forwardmediawiki/extensions/PageTriagemaster+44 -6
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Oct 17 2023, 1:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2023, 1:09 AM
MPGuy2824 subscribed.Oct 17 2023, 7:06 AM

If we want the log format exactly as written in the task, it probably would require changes to mediawiki-core, as well as pagetriage.
Another option would be use the 'note' api parameter while marking as reviewed/unreviewed. Assuming 'note' is set to 'article', it would leave a log as follows:
Hey man im josh (talk | contribs | block) marked Columbia 'Coco' Diaz as reviewed (article)

Novem_Linguae added a comment.Oct 17 2023, 7:10 AM

MediaWiki core?

Any reason we couldn't just change this message in PageTriage from

"logentry-pagetriage-curation-reviewed": "$1 {{GENDER:$2|marked}} $3 as reviewed",

to use a $4 parameter, or split it into two messages?

Soda subscribed.Oct 17 2023, 11:36 AM
In T349048#9256572, @Novem_Linguae wrote:

MediaWiki core?

Any reason we couldn't just change this message in PageTriage from

"logentry-pagetriage-curation-reviewed": "$1 {{GENDER:$2|marked}} $3 as reviewed",

to use a $4 parameter, or split it into two messages?

Yes it can :)

Soda claimed this task.Oct 17 2023, 11:37 AM
gerritbot added a comment.Oct 17 2023, 11:39 AM

Change 966517 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Differentiate between redirects and articles in review logs going forward

https://gerrit.wikimedia.org/r/966517

gerritbot added a project: Patch-For-Review.Oct 17 2023, 11:39 AM
Soda added a comment.Oct 17 2023, 11:40 AM

That being said, this can only be applied to logs going forward, changing anything that has already been logged is going to be non-trivial

Soda moved this task from Backlog to Code Review on the PageTriage board.Oct 17 2023, 1:55 PM
Novem_Linguae added a comment.Oct 17 2023, 5:48 PM

Going forward sounds fine to me :)

MPGuy2824 added a comment.Oct 18 2023, 5:21 AM

Obviously, I didn't know how the logentry stuff worked. Frantic searching in the PT and MW-core codebases gave nothing relevant.

Anyway, Soda's patch seems to do everything that is asked for in the ticket.

In T349048#9256572, @Novem_Linguae wrote:

MediaWiki core?

Any reason we couldn't just change this message in PageTriage from

"logentry-pagetriage-curation-reviewed": "$1 {{GENDER:$2|marked}} $3 as reviewed",

to use a $4 parameter, or split it into two messages?

Novem_Linguae added a comment.Oct 22 2023, 5:02 PM

Looks like this would also help with tallying points for the NPP backlog drive. Since articles and redirects sometimes have different point values. And we need a way to track these even after the articles are deleted.

https://en.wikipedia.org/wiki/User_talk:Tol#NPP_backlog_drive_issue

Samwalton9-WMF added a project: Moderator-Tools-Team (Kanban).Oct 24 2023, 11:28 AM
Samwalton9-WMF moved this task from Ready to Code review on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Oct 27 2023, 1:19 AM
Pppery awarded a token.Oct 29 2023, 4:35 AM
gerritbot added a comment.Oct 31 2023, 12:16 AM

Change 966517 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Differentiate between redirects and articles in review logs going forward

https://gerrit.wikimedia.org/r/966517

Scardenasmolinar moved this task from Reviewed (waiting for changes) to Done on the Moderator-Tools-Team (Kanban) board.Oct 31 2023, 12:20 AM
Scardenasmolinar moved this task from Code Review to Done on the PageTriage board.
Scardenasmolinar moved this task from Done to Waiting for enwiki deploy on the PageTriage board.
Maintenance_bot removed a project: Patch-For-Review.Oct 31 2023, 12:30 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.3; 2023-10-31).Oct 31 2023, 1:00 AM
Scardenasmolinar closed this task as Resolved.Nov 7 2023, 5:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL