Page MenuHomePhabricator
Create Task
Maniphest T349082

User rights: Logged in users can edit user-contributed objects of non-restricted types
Closed, ResolvedPublic
Actions

Description

Description

Any logged in user can edit anything else that doesn't fall on specific restrictions (by type, state, or zid range)

  • Set wikilambda-edit to true for the group user (remove corePermissions override)
  • Set wikilambda-implementation to true for the group user (remove corePermissions override)
    • This permission is currently not used, but it could be useful, so add a specific type rule into authorizationRules.yml
  • Set wikilambda-tester to true for the group user (remove corePermissions override)
    • This permission is currently not used, but it could be useful, so add a specific type rule into authorizationRules.yml

Completion checklist

Details

SubjectRepoBranchLines +/-
[wikifunctions] Alter site to General Availabilityoperations/mediawiki-configmaster+13 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

gengh created this task.Oct 17 2023, 10:47 AM
gengh mentioned this in T349054: Adjust and improve Wikifunctions user rights grants for General Availability.
Jdforrester-WMF added a parent task: T349054: Adjust and improve Wikifunctions user rights grants for General Availability.Oct 17 2023, 2:05 PM
gerritbot added a comment.Oct 17 2023, 4:14 PM

Change 966570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/mediawiki-config@master] [wikifunctions] Alter site to General Availability

https://gerrit.wikimedia.org/r/966570

gerritbot added a project: Patch-For-Review.Oct 17 2023, 4:14 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 19 2023, 4:39 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF assigned this task to gengh.Oct 20 2023, 1:35 PM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF edited projects, added MW-1.42-notes (1.42.0-wmf.2; 2023-10-24); removed Patch-For-Review.Oct 25 2023, 1:45 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Oct 26 2023, 3:19 PM
gerritbot added a comment.Nov 7 2023, 2:02 PM

Change 966570 merged by jenkins-bot:

[operations/mediawiki-config@master] [wikifunctions] Alter site to General Availability

https://gerrit.wikimedia.org/r/966570

Stashbot added a comment.Nov 7 2023, 2:03 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:03:16Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]]

Stashbot mentioned this in T349063: User rights: Logged in users can edit function input labels and key labels.Nov 7 2023, 2:03 PM
Stashbot mentioned this in T349061: User rights: Logged in users can create functions, implementations, tests and others.
Stashbot mentioned this in T349080: User rights: Logged in users can edit user-contributed functions that are not-running.

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:04:43Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Nov 7 2023, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-07T14:10:17Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:966570|[wikifunctions] Alter site to General Availability (T349054 T349061 T349063 T349080 T349082)]] (duration: 07m 00s)

Etonkovidova closed this task as Resolved.Nov 18 2023, 12:50 AM
Etonkovidova mentioned this in T351577: User warnings when editing objects should be more specific.
Etonkovidova subscribed.

Checked - works as expected.

Note: for restricted types, e.g. Core types, the error "User does not have permission to edit" comes after a user hits Publish button - filed as a separate task: T351577.

Etonkovidova updated the task description. (Show Details)Nov 18 2023, 12:53 AM
Etonkovidova updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL