Inline diff displays two of the same paragraph (sometimes?), one with a relevant change and one without, leading to confusion
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Izno
	Oct 19 2023, 5:58 PM

Description

Steps to replicate the issue (include links if applicable):

View https://en.wikipedia.org/w/index.php?title=Talk%3ANicotine&diff=1180919346&oldid=1176770800

What happens?:
Two versions of the paragraph starting with {{ Reliable sources for medical articles |small=y}} and {{ Copied |small=y |from=Safety of electronic cigarettes |to=Nicotine |from_oldid=648699329 |to_oldid=748186597| to_diff=748187041}} display in inline. The first one displays the removed text and the second one does not. This looks like it's due to diffing not catching the move of the paragraph, but that it caught the removed space?...

Neither block nor WikEdDiff seem to have this issue:

What should have happened instead?:

Display only one version.

Software version: 1.41.0-wmf.30 (2623e02)
18:49, 9 October 2023
wikidiff2 1.14.1

Other information: Firefox 118.0.2 on Windows 10.

Related Objects

Mentioned Here: T327642: Inline diff sometimes ignores inserted/deleted spaces
rMW2623e02f4e02: Merge "Parser: remove usages of $wgTitle"

Event Timeline

Izno created this task.Oct 19 2023, 5:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2023, 5:58 PM

Or rather, it looks like everything got duplicated and I was just noticing the bottom version?

I think this was resolved with T327642, but that shipped in July and this was filed in October. At any rate, things look right to me now:

Screenshot from 2023-12-06 14-53-54.png (768×1 px, 171 KB)

@Izno Can you confirm?

Something isn't fixed here, T349335#9266311 is the real issue and still exists. I'm getting both a "top" diff and a "bottom" diff that would correspond to before/after in column mode. I've got two instances in that diff of {{reliable sources for medical articles |small=y}} for a specific example, one with the del and one without.

I think this is "wikidiff still bad at detecting paragraph changes/moves/removals" but this is how it's manifesting in inline.

Izno renamed this task from Removed space is lost when a paragraph location is adjusted, in inline diff to Inline diff displays two of the same paragraph (sometimes?), one with a relevant change and one without, leading to confusion.Jan 6 2024, 11:49 PM

Izno updated the task description. (Show Details)

Nardog subscribed.Sun, May 26, 5:49 PM

	F41566653: Screenshot from 2023-12-06 14-53-54.png
	Dec 6 2023, 7:55 PM

	F38832631: image.png
	Oct 19 2023, 5:59 PM

Inline diff displays two of the same paragraph (sometimes?), one with a relevant change and one without, leading to confusionOpen, Needs TriagePublicBUG REPORTActions

Description

Related Objects

Event Timeline

Inline diff displays two of the same paragraph (sometimes?), one with a relevant change and one without, leading to confusion
Open, Needs TriagePublicBUG REPORT
Actions