Change 982460 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Curation toolbar: fix window resize position bug

https://gerrit.wikimedia.org/r/982460

I have reviewed this bug fix and only have one comment. The behavior is mostly the same (and the bug is fixed), except when you move the toolbar and resize the window.

In the old version, when you move the toolbar to a more central position and then resize the window, it disappears and does not change its position.

In the new version, the toolbar moves when you do the same action.

I personally think that the new version's behavior is better than the old one. If no one has any objections, I will +2 this patch later on in the week.

Test wiki created on Patch demo by Samwalton9 (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/3ba84a34f6/w

In T349403#9401786, @Scardenasmolinar wrote:

I have reviewed this bug fix and only have one comment. The behavior is mostly the same (and the bug is fixed), except when you move the toolbar and resize the window.

I personally think that the new version's behavior is better than the old one. If no one has any objections, I will +2 this patch later on in the week.

Hmm, the new behaviour is also kind of unintuitive to me. It doesn't seem to be possible to re-dock the bar and you can completely lose it if you move the toolbar and resize past it. This matches the old behaviour, so it's not a blocker to the patch, it just leaves me wondering if moving the toolbar even a desirable feature.

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d7da16acac/wiki/Special:NewPagesFeed?pagetriage_tb=new

@Samwalton9-WMF I think you were testing the "old" behavior since you weren't using the url parameter, however I found and fixed another little bug. Here is a real test:
https://patchdemo.wmflabs.org/wikis/d7da16acac/w/index.php?title=Test&pagetriage_tb=new

In T349403#9402633, @Samwalton9-WMF wrote:

In T349403#9401786, @Scardenasmolinar wrote:

I have reviewed this bug fix and only have one comment. The behavior is mostly the same (and the bug is fixed), except when you move the toolbar and resize the window.

I personally think that the new version's behavior is better than the old one. If no one has any objections, I will +2 this patch later on in the week.

Hmm, the new behaviour is also kind of unintuitive to me. It doesn't seem to be possible to re-dock the bar and you can completely lose it if you move the toolbar and resize past it. This matches the old behaviour, so it's not a blocker to the patch, it just leaves me wondering if moving the toolbar even a desirable feature.

Ignore this comment - I've just realised I forgot to use the URL parameter to test the new version. Having a set distance from the right-hand side makes a lot of sense and means it's always on screen as you resize. Looks great to me.

Change 982460 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Curation toolbar: fix window resize position bug

https://gerrit.wikimedia.org/r/982460

Test wiki on Patch demo by Samwalton9 (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/3ba84a34f6/w/

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d7da16acac/w/