Page MenuHomePhabricator
Create Task
Maniphest T349442

Remove explicit DB access for extension Math
Closed, ResolvedPublic
Actions

Description

Math has implemented explicit functions to cache rendering in the database, which is not used in production. All new code uses BagOfStuff cache, which might also end up in the database, depending on the settings. Therefore, I don't see a reason to keep the math(oid|latexml) tables.

MathSearch uses the inputhash and the inputtex in some situations, but this can be replaced with onMathRenderingResultRetrieved which in the end reduces join conditions.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove unused MathIdGenerator::getInputHashPhysikerweltmediawiki/extensions/MathSearchmaster+0 -4
Remove unused MathRenderer::getMathTableNameKrinklemediawiki/extensions/Mathmaster+15 -65
Remove dead MathObject::getMathTableNamePhysikerweltmediawiki/extensions/MathSearchmaster+0 -4
Remove unused MathRenderer::dbInArrayKrinklemediawiki/extensions/Mathmaster+0 -23
Stop depending on MathRenderer::dbInArrayPhysikerweltmediawiki/extensions/MathSearchmaster+1 -4
Remove dependency on math database fieldsPhysikerweltmediawiki/extensions/MathSearchmaster+37 -34
Remove explicit DB accessPhysikerweltmediawiki/extensions/Mathmaster+266 -666
Remove access to getMathTableNamePhysikerweltmediawiki/extensions/MathSearchmaster+2 -2
Use mathlog table for special pagePhysikerweltmediawiki/extensions/MathSearchmaster+75 -32
Customize query in gerrit

Related Objects
Search...

Event Timeline

Physikerwelt created this task.Oct 22 2023, 6:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2023, 6:25 AM
Physikerwelt updated the task description. (Show Details)Oct 22 2023, 6:43 AM
gerritbot added a comment.Oct 29 2023, 1:54 PM

Change 969507 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Use mathlog table for special page

https://gerrit.wikimedia.org/r/969507

gerritbot added a project: Patch-For-Review.Oct 29 2023, 1:54 PM
gerritbot added a comment.Oct 29 2023, 2:50 PM

Change 969507 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Use mathlog table for special page

https://gerrit.wikimedia.org/r/969507

Physikerwelt mentioned this in rEMAS0bdc5cc87429: Use mathlog table for special page.Oct 29 2023, 2:50 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 29 2023, 3:10 PM
gerritbot added a comment.Oct 31 2023, 12:09 PM

Change 970343 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Remove access to getMathTableName

https://gerrit.wikimedia.org/r/970343

gerritbot added a project: Patch-For-Review.Oct 31 2023, 12:09 PM
gerritbot added a comment.Oct 31 2023, 3:17 PM

Change 970343 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Remove access to getMathTableName

https://gerrit.wikimedia.org/r/970343

Physikerwelt mentioned this in rEMAS29a75a5f9d6a: Remove access to getMathTableName.Oct 31 2023, 3:19 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 31 2023, 3:29 PM
Physikerwelt claimed this task.Jan 11 2024, 3:39 PM
gerritbot added a comment.Jan 11 2024, 3:43 PM

Change 975432 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Remove explicit DB access

https://gerrit.wikimedia.org/r/975432

gerritbot added a project: Patch-For-Review.Jan 11 2024, 3:43 PM
Ladsgroup subscribed.Jan 15 2024, 9:57 AM

You'll need to create a dedicated ticket tagged with DBA for dropping the tables in production.

gerritbot added a comment.Jan 15 2024, 10:08 AM

Change 975432 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove explicit DB access

https://gerrit.wikimedia.org/r/975432

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2024, 10:31 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 15 2024, 11:00 AM
Physikerwelt mentioned this in T355050: SQL: DROP TABLE IF EXISTS mathoid, mathlatexml;.Jan 15 2024, 11:38 AM
gerritbot added a comment.Jan 16 2024, 9:04 PM

Change 975433 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Remove dependency on MathDB fields

https://gerrit.wikimedia.org/r/975433

gerritbot added a project: Patch-For-Review.Jan 16 2024, 9:04 PM
Marostegui changed the status of subtask T355050: SQL: DROP TABLE IF EXISTS mathoid, mathlatexml; from Open to Stalled.Jan 17 2024, 11:46 AM
gerritbot added a comment.Jan 17 2024, 10:20 PM

Change 975433 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Remove dependency on math database fields

https://gerrit.wikimedia.org/r/975433

Maintenance_bot removed a project: Patch-For-Review.Jan 17 2024, 10:31 PM
Physikerwelt mentioned this in rEMAS9b8799e9bc3b: Remove dependency on math database fields.Jan 18 2024, 1:29 AM
Ladsgroup changed the status of subtask T355050: SQL: DROP TABLE IF EXISTS mathoid, mathlatexml; from Stalled to Open.Jan 23 2024, 11:16 AM
Physikerwelt closed subtask T355673: Check math BagOStuff cache as Resolved.Jan 24 2024, 7:20 AM
Marostegui closed subtask T355050: SQL: DROP TABLE IF EXISTS mathoid, mathlatexml; as Resolved.Feb 5 2024, 11:07 AM
Physikerwelt closed this task as Resolved.Feb 10 2024, 8:03 AM
pmiazga mentioned this in T358236: Cannot create a new wiki on beta cluster.Feb 22 2024, 3:51 PM
gerritbot added a comment.Thu, Sep 17, 12:08 PM

Change #1342651 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Math@master] Remove unused MathRenderer::dbInArray

https://gerrit.wikimedia.org/r/1342651

gerritbot added a project: Patch-For-Review.Thu, Sep 17, 12:08 PM
gerritbot added a comment.Thu, Sep 17, 12:11 PM

Change #1342654 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Math@master] Remove unused MathRenderer::getMathTableName

https://gerrit.wikimedia.org/r/1342654

gerritbot added a comment.Thu, Sep 17, 4:14 PM

Change #1342738 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Stop depending on MathRenderer::dbInArray

https://gerrit.wikimedia.org/r/1342738

gerritbot added a comment.Thu, Sep 17, 4:39 PM

Change #1342738 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Stop depending on MathRenderer::dbInArray

https://gerrit.wikimedia.org/r/1342738

gerritbot added a comment.Thu, Sep 17, 5:05 PM

Change #1342651 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove unused MathRenderer::dbInArray

https://gerrit.wikimedia.org/r/1342651

gerritbot added a comment.Thu, Sep 17, 5:08 PM

Change #1342760 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Remove dead MathObject::getMathTableName

https://gerrit.wikimedia.org/r/1342760

gerritbot added a comment.Thu, Sep 17, 5:55 PM

Change #1342654 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove unused MathRenderer::getMathTableName

https://gerrit.wikimedia.org/r/1342654

gerritbot added a comment.Thu, Sep 17, 5:55 PM

Change #1342760 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Remove dead MathObject::getMathTableName

https://gerrit.wikimedia.org/r/1342760

Maintenance_bot removed a project: Patch-For-Review.Thu, Sep 17, 6:31 PM
gerritbot added a comment.Sat, Oct 10, 6:47 AM

Change #1354141 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Remove unused MathIdGenerator::getInputHash

https://gerrit.wikimedia.org/r/1354141

gerritbot added a project: Patch-For-Review.Sat, Oct 10, 6:47 AM
gerritbot added a comment.Sat, Oct 10, 6:54 AM

Change #1354141 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Remove unused MathIdGenerator::getInputHash

https://gerrit.wikimedia.org/r/1354141

Maintenance_bot removed a project: Patch-For-Review.Sat, Oct 10, 7:30 AM
gerritbot added a comment.Tue, Oct 13, 6:04 PM

Change #1354086 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Close the gap between mathlog and mathindex

https://gerrit.wikimedia.org/r/1354086

gerritbot added a project: Patch-For-Review.Tue, Oct 13, 6:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits