Page MenuHomePhabricator

Remove phonetic notation from article text selection
Closed, ResolvedPublic

Assigned To
Authored By
hueitan
Oct 23 2023, 8:11 AM
Referenced Files
F41553471: 2023-12-01_15-15-12.png
Dec 1 2023, 11:23 PM
F41553469: 2023-12-01_15-16-06.png
Dec 1 2023, 11:23 PM
F41553467: 2023-12-01_15-17-02.png
Dec 1 2023, 11:23 PM
F41553465: 2023-12-01_15-16-31.png
Dec 1 2023, 11:23 PM
F41553463: 2023-12-01_15-16-06.png
Dec 1 2023, 11:23 PM
F41544312: Wikistory_Phonos_issue.webm
Nov 28 2023, 9:53 PM
F39677685: image.png
Oct 23 2023, 8:11 AM
F39677684: image.png
Oct 23 2023, 8:11 AM

Description

Event Timeline

hueitan renamed this task from Article text section for pronunciation to Article text selection for pronunciation.Oct 23 2023, 8:11 AM
hueitan updated the task description. (Show Details)
PWaigi-WMF triaged this task as Medium priority.Oct 23 2023, 2:26 PM
SBisson renamed this task from Article text selection for pronunciation to Remove phonetic notation from article text selection.Oct 25 2023, 4:17 PM

Change 968749 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Remove phonetics notation in first paragraph

https://gerrit.wikimedia.org/r/968749

Change 968749 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Remove phonetics notations

https://gerrit.wikimedia.org/r/968749

PWaigi-WMF changed the task status from Open to In Progress.Nov 17 2023, 5:41 PM

@SBisson I created T352216: Wikistory: unparsed and broken HTML code regarding what we talked about yesterday. I also see the phonetic notation in Beta as seen in the .webm below. If I did this incorrectly, please let me know, thanks!

Status: ❌Fail
Environment: Beta: 1.42.0-alpha (d31da40)
OS: macOS Sonoma 14.1
Browser: Chrome 119
Skins. Mobile View
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Wikistory_Phonos

❌AC1: https://phabricator.wikimedia.org/T349480

On the Wikistory Phonos article mentioned above, the API notation is written as <nowiki>{{IPA-ar|as.sa.laː.mu ʕa.laj.kum|lang|Ar-السلام_عليكم.oga}}</nowiki> so it is meant to be displayed literally and shouldn't be removed by the Wikistories article view.

The other issue (visible HTML) is due to T352216: Wikistory: unparsed and broken HTML code and completely unrelated to phonetic notation.

@SBisson Got it, Phonotic notations are removed as seen below. I did come across new HTML issues as seen in https://phabricator.wikimedia.org/T352216#9376456. As for this one though, I will move this to Design sign-off. Thanks for all your work!

Status: ✅Pass
Environment: ID PROD
OS: macOS Sonoma 14.1
Browser: Chrome 119
Skins. Mobile View
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://id.wikipedia.org/wiki/Abul_Kalam_Azad
https://id.wikipedia.org/wiki/Homi_J._Bhabha

✅AC1: https://phabricator.wikimedia.org/T349480

https://id.wikipedia.org/wiki/Homi_J._Bhabha

ArticleBefore PatchAfter Patch
2023-12-01_15-16-06.png (857×959 px, 255 KB)
2023-12-01_15-16-31.png (1×857 px, 786 KB)
2023-12-01_15-17-02.png (1×875 px, 618 KB)

https://id.wikipedia.org/wiki/Abul_Kalam_Azad

2023-12-01_15-16-06.png (857×959 px, 255 KB)
2023-12-01_15-15-12.png (1×2 px, 736 KB)