Page MenuHomePhabricator
Create Task
Maniphest T349924

Update is_pinned condition to disgard TOC state
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
Jdlrobson
Authored By
KSarabia-WMF
Oct 27 2023, 4:32 PM
Tags
Referenced Files
F41520710: screenshot 258.png
Nov 19 2023, 8:46 PM
F41520709: screenshot 261.png
Nov 19 2023, 8:46 PM
F41520708: screenshot 259.png
Nov 19 2023, 8:46 PM
F41520707: screenshot 260.png
Nov 19 2023, 8:46 PM
F41484935: screenshot 200.png
Nov 10 2023, 10:26 PM
F41484934: screenshot 199.png
Nov 10 2023, 10:26 PM
F41484933: screenshot 198.png
Nov 10 2023, 10:26 PM
F41484932: screenshot 201.png
Nov 10 2023, 10:26 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
Jdrewniak
KSarabia-WMF
ovasileva

Description

The TOC pinned state being default distracts the baseline data collection process because we have to track the pinned component adaptation of users. Currently, the condition will return true if one of three pinnable components (TOC, main menu, and page tools) is pinned, but we should update it so it will only return true if either main menu and page tools is pinned, disregarding the pinned/unpinned state of TOC.

QA Results - Beta

ACStatusDetails
1✅T349924#9324258

QA Results - Prod

ACStatusDetails
1✅T349924#9343335

Details

SubjectRepoBranchLines +/-
Remove TOC state from logicmediawiki/skins/Vectormaster+15 -0
Update function namemediawiki/extensions/WikimediaEventsmaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

KSarabia-WMF created this task.Oct 27 2023, 4:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2023, 4:32 PM
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3); removed Web-Team-Backlog.Oct 31 2023, 11:46 PM
ovasileva triaged this task as High priority.Nov 2 2023, 5:16 PM
ovasileva added a parent task: T346979: Report on baseline for interface customization.
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva added subscribers: Jdrewniak, ovasileva.Nov 2 2023, 5:19 PM

Discussed in grooming and we're not quite ready to estimate. @KSarabia-WMF and @Jdrewniak to discuss further. Let's try to estimate again Mon, Nov 6

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 2 2023, 5:53 PM
Jdrewniak added a comment.Nov 6 2023, 5:24 PM

After talking with @KSarabia-WMF , we decided to rename the PinnableElement.hasPinnedElement() function to reflect the fact that it is specifically used for Event logging. With that change, we can add conditional logic inside that function. to track certain elements and disregard others, without affecting the PinnableElement.isPinned() function, which is more broadly used.

KSarabia-WMF claimed this task.Nov 6 2023, 6:21 PM
KSarabia-WMF moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.
KSarabia-WMF unsubscribed.
KSarabia-WMF subscribed.
Jdlrobson set the point value for this task to 2.Nov 6 2023, 6:24 PM
gerritbot added a comment.Nov 7 2023, 4:47 PM

Change 972421 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Remove TOC state from logic

https://gerrit.wikimedia.org/r/972421

gerritbot added a project: Patch-For-Review.Nov 7 2023, 4:47 PM
KSarabia-WMF moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 7 2023, 4:49 PM
gerritbot added a comment.Nov 8 2023, 8:09 PM

Change 972888 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/extensions/WikimediaEvents@master] Update function name

https://gerrit.wikimedia.org/r/972888

gerritbot added a comment.Nov 8 2023, 8:43 PM

Change 972421 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove TOC state from logic

https://gerrit.wikimedia.org/r/972421

gerritbot added a comment.Nov 8 2023, 8:43 PM

Change 972888 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Update function name

https://gerrit.wikimedia.org/r/972888

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 8 2023, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 8 2023, 9:10 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.Nov 8 2023, 9:11 PM
KSarabia-WMF added a comment.Nov 9 2023, 6:09 PM

QA Steps

  • Go to Network Tab
  • Previously, is_pinned: will return true if one of three pinnable components (TOC, main menu, and page tools) is pinned.
  • Now, it should only return true if either main menu and page tools is pinned, disregarding the pinned/unpinned state of TOC.
KSarabia-WMF reassigned this task from KSarabia-WMF to Edtadros.Nov 9 2023, 6:09 PM
Edtadros removed Edtadros as the assignee of this task.EditedNov 10 2023, 10:26 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to Network Tab
Previously, is_pinned: will return true if one of three pinnable components (TOC, main menu, and page tools) is pinned.
✅ AC1: Now, it should only return true if either main menu and page tools is pinned, disregarding the pinned/unpinned state of TOC.
@KSarabia-WMF can you please confirm if this should also work for anon users? I'm passing this since it works for logged in users.

screenshot 201.png (1×1 px, 277 KB)

screenshot 198.png (1×1 px, 247 KB)

screenshot 199.png (1×1 px, 245 KB)

screenshot 200.png (1×1 px, 263 KB)

Edtadros updated the task description. (Show Details)Nov 12 2023, 11:14 PM
Jdlrobson closed this task as Resolved.Nov 13 2023, 6:18 PM
Jdlrobson claimed this task.
Jdlrobson subscribed.

Per @KSarabia-WMF we do not need to do any further verification here.

Edtadros added a project: Verified.Nov 19 2023, 8:46 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Go to Network Tab
Previously, is_pinned: will return true if one of three pinnable components (TOC, main menu, and page tools) is pinned.
✅ AC1: Now, it should only return true if either main menu and page tools is pinned, disregarding the pinned/unpinned state of TOC.

screenshot 260.png (1×1 px, 334 KB)

screenshot 259.png (1×1 px, 361 KB)

screenshot 261.png (1×1 px, 361 KB)

screenshot 258.png (1×1 px, 363 KB)

Edtadros updated the task description. (Show Details)Nov 19 2023, 8:48 PM
Edtadros mentioned this in T350416: Verify 1.42.0-wmf.5 deployment.Nov 19 2023, 9:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL