| Yair_rand | |
| Dec 14 2011, 12:10 AM |
| F8760: bug33064.patch | |
| Nov 22 2014, 12:08 AM |
Pressing ctrl + left or right arrow key is supposed to move the caret one word over. (Or at least, that's the normal result in most text editors, I think...) In VisualEditor if you have, for example: ("|" represents the caret)
...Lorem| ipsum
and the user presses ctrl+right, the result is
...Lorem |ipsum
when it is supposed to result in
...Lorem ipsum|
Version: unspecified
Severity: normal
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Inez | T41315 VisualEditor: Selection issues re-write | |||
| Resolved | Inez | T35064 VisualEditor: Ctrl+left/right to jump by word does not work properly | |||
| Resolved | None | T35128 Ctrl+left/right arrow doesn't work correctly with non-Latin scripts | |||
| Resolved | None | T35127 Double-clicking a word selects several non-Latin words |
More precisely, the caret visits every word twice - at the beginning and at the end:
Lorem| ipsum dolor sit amet
Lorem |ipsum dolor sit amet
Lorem ipsum| dolor sit amet
Lorem ipsum |dolor sit amet
Lorem ipsum dolor| sit amet
Lorem ipsum dolor |sit amet
Lorem ipsum dolor sit| amet
Lorem ipsum dolor sit |amet
Lorem ipsum dolor sit amet|
And i would expect something like:
Lorem| ipsum dolor sit amet
Lorem |ipsum dolor sit amet
Lorem ipsum |dolor sit amet
Lorem ipsum dolor |sit amet
Lorem ipsum dolor sit |amet
Another consideration:
I'm not a Mac person, but AFAIK Ctrl-←/→ on OS X does something like Home/End - jumps to the beginning/end of the line. So for Mac users this should emulate their OS' behavior.
ashish.dubey91 wrote:
This implementation fixes the bug for me.
I made a small tweak in es.SurfaceView.js which gives me the expected result as mentioned above.
Awaits review.
Attached:
sumanah wrote:
Ashish, thank you for the patch. I have added the keywords "patch" and "need-review" to indicate that this bug has a patch that needs to be reviewed. Next time, you can do this yourself when you attach the patch, to save time.
Trevor, maybe you could take a look at this?
This patch works, but is still incomplete because it doesn't handle punctuation properly.
On a Mac, using option+left/right yields the following results:
Forwards:
|This.is.a.test of how.things work. if, there-is punctuation. This.is.a.test| of how.things work. if, there-is punctuation. This.is.a.test of| how.things work. if, there-is punctuation. This.is.a.test of how.things| work. if, there-is punctuation. This.is.a.test of how.things work|. if, there-is punctuation. This.is.a.test of how.things work. |if, there-is punctuation. This.is.a.test of how.things work. if|, there-is punctuation. This.is.a.test of how.things work. if, there|-is punctuation. This.is.a.test of how.things work. if, there-is| punctuation. This.is.a.test of how.things work. if, there-is punctuation|. This.is.a.test of how.things work. if, there-is punctuation.|
Backwards:
This.is.a.test of how.things work. if, there-is punctuation.| This.is.a.test of how.things work. if, there-is |punctuation. This.is.a.test of how.things work. if, there-|is punctuation. This.is.a.test of how.things work. if, |there-is punctuation. This.is.a.test of how.things work. |if, there-is punctuation. This.is.a.test of how.things |work. if, there-is punctuation. This.is.a.test of |how.things work. if, there-is punctuation. This.is.a.test |of how.things work. if, there-is punctuation. |This.is.a.test of how.things work. if, there-is punctuation.
It's important to note that hyphens (-) are treated as whitespace. Thus the following two lines will behave identically forwards and backwards.
a -b c- d-e f
a b c d e f
The logic appears to be something like this:
If the patch is updated to follow that logic, that should work well on Mac, but may still not work correctly on other platforms. This is because, as mentioned, moving the cursor by word may differ on Windows or Linux, and we should probably aim to provide a consistent experience on each platform.
If someone can analyze the behavior of other platforms that would be useful.
Also, please note in the examples above, there are three classes of punctuation which seem to behave differently.
a!b a@b a#b a%b a&b a*b a(b a)b a-b a{b a}b a[b a]b a\b a;b a"b a,b a?b a/b
a$b a^b a+b a=b a|b a<b a>b
a_b a:b a'b a.b
This might also vary from platform to platform.
Also, if you can put together a patch that does this correctly, perhaps some
documentation on the wiki about the different cursor movement rules for each
platform would be awesome.
This is a great project for someone getting into VE work, and we would really
appreciate some help in these areas where the details are important but we are
mostly busy forging ahead with missing functionality.
Thanks for the patch so far, I look forward to getting this working properly.
From
I was trying to use CTRL+Left arrow to move the cursor to the left, but it only moves one character at time (instead of one word at time).
Curiously, it works fine for selection (i.e. CTRL+SHIFT+Left arrow).
For the record, here is what I get on Ubuntu 12.04, using gedit 3.4.1 for the examples from comment 7 (I inserted a "|" on each place the cursor stops when going to each direction):
Forwards:
| a | !b | a | @B | a | #b | a | %b | a | &b | a | *b | a | (b | a | )b | a | -b | a | {b | a | }b | a | [b | a | ]b | a | \b | a | ;b | a | "b | a | ,b | a | ?b | a | /b |
| a | $b | a | ^b | a | +b | a | =b | a | b | a | <b | a | >b | |
| a | _b | a | :b | a | 'b | a | .b |
Backwards:
| a! | b | a@ | b | a# | b | a% | b | a& | b | a* | b | a( | b | a) | b | a- | b | a{ | b | a} | b | a | b | a] | b | a\ | b | a; | b | a" | b | a, | b | a? | b | a/ | b |
| a$ | b | a^ | b | a+ | b | a= | b | a | b | a< | b | a> | b | |
| a_ | b | a: | b | a' | b | a. | b |
Here's how it is for me (also some related issues):
Firefox 11.0 on Ubuntu 10.10.
Very weird:
ш appears at the cursor. A new paragraph is created above the current paragraph. ш also appear at the new paragraph, but is overwritten with the next letter I type. Doesn't happen every time, but I managed to trigger it multiple times.
(In reply to comment #9)
From
https://www.mediawiki.org/w/index.php?title=Visual_editor/Feedback&oldid=552919#CTRL.2BLeft_arrow_doesn.27t_work_as_expected
I was trying to use CTRL+Left arrow to move the cursor to the left, but it only
moves one character at time (instead of one word at time).
Curiously, it works fine for selection (i.e. CTRL+SHIFT+Left arrow).The right arrow behaves the same way as the left one.
For the record, this test was done using Firefox 9.0.1 on Windows XP, but the same problem happens on Ubuntu 12.04 using either Chrome 19.0.1084.56 or Firefox 13.0.1.
(In reply to comment #16)
And now it's broken again. Ctrl+left/right is moving one character at a time
again.
What version of the code were you running? Some details about your browser set-up/etc. would be helpful to debug.
If you're talking about the version running on MediaWiki.org, note that is updated every fortnight and that it has not yet had this code go live.
What version of the code were you running? Some details about your browser
set-up/etc. would be helpful to debug.If you're talking about the version running on MediaWiki.org, note that is
updated every fortnight and that it has not yet had this code go live.
Oh, sorry. I was indeed talking about the version on Mediawiki.org. The Mediawiki.org version now seems to have the issue resolved. (Is there a way to test just the most recent version of VisualEditor?)
Not on MediaWiki.org (as with other wikis, that runs the current deployed version). In the future we intend to have a labs machine running the live head, but that's not yet something we've built.
I'm also testing on mediawiki.org but these haven't been mentioned before so I don't believe they're fixed in git.
Various key combinations behave very weirdly for me.
for the entire paragraph).
the entire paragraph and select the text).
Firefox 16.0.1 on Windows XP SP 2.
orbit wrote:
Nikola, thank you for such a thorough check. In this whole project, we've been balancing which features we allow the browser to do natively vs. which we handle programmatically. In this last release, we gave the power back to the browser for most cursor movement.
Ctrl + ↑ and Ctrl + ↓ don't have any native behavior in Firefox. We could programmatically move the cursor to the beginning or end of the paragraph though, but we'd handle it in a separate enhancement request.
With the End key issue that you described, again, we're letting Firefox do what it does natively.
The selection stuff is a huge goof on our part. I've got a fix committed and reviewed. We'll release to mediawiki.org in the morning.