Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.
It improves readability and security of the code and is more aligned with industry practices easing onboarding.
For more information check T210206 and T350075.
Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.
Relevant codesearches:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T350075 Migrate raw SQL building in conditions to expression builder in WMF-deployed extensions | |||
| Resolved | Umherirrender | T350966 Use expression builder instead of raw SQL in PageTriage | |||
| Resolved | MPGuy2824 | T350986 Use expression builder instead of raw SQL in ORES |
Change 990038 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/PageTriage@master] Use IDatabase::expr for complex conditions
Change 994393 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):
[mediawiki/extensions/PageTriage@master] Use expression builder instead of raw SQL in PageTriage
Change 994393 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Replace addQuotes() with expression builder
Change 990038 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use IDatabase::expr for complex conditions
Will leave this open for now. Looks like there's still 2 makeLists left.
https://codesearch.wmcloud.org/search/?q=makeList&files=&excludeFiles=&repos=Extension%3APageTriage
Change 1004319 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):
[mediawiki/extensions/PageTriage@master] replace makeList() with expr()
Change #1055592 had a related patch set uploaded (by Umherirrender; author: Umherirrender):
[mediawiki/extensions/PageTriage@master] Use expression builder to avoid IDatabase::makeList
Change #1055592 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use expression builder to avoid IDatabase::makeList