Page MenuHomePhabricator

Redirects to an article should not be considered when considering if it(the article) is an orphan or not
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create a new article
  • The article correctly shows on the NewPagesFeed as an Orphan
  • Create a redirect to the article
  • Do a null edit on the article, so that Page Triage redoes the metadata compiling

What happens?:
The article's orphan tag goes away, although https://en.wikipedia.org/wiki/Wikipedia:Orphan#Criteria says that "The following pages do not count as incoming links: . . . Redirects and Soft redirects"

What should have happened instead?:
The article should continue to be tagged as an orphan

Event Timeline

Change 975907 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Use freshly computed linkcount to display orphan status in toolbar

https://gerrit.wikimedia.org/r/975907

Soda moved this task from Backlog to Code Review on the PageTriage board.

Change 975907 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Use freshly computed linkcount to display orphan status in toolbar

https://gerrit.wikimedia.org/r/975907

Bug still present. e.g https://en.wikipedia.org/wiki/Dragašević is only linked from a redirect, but it doesn't show as an orphan in NewPageFeed.

Has this patch been deployed ? There isn't a version tag on this task ? (Maybe we can check if this works on beta ?)

Has this patch been deployed ?

Yes, the other ticket is solved on prod. Also see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/refs/heads/wmf/1.42.0-wmf.9. It happened to be the commit at which the 1.42.0-wmf.9 release branch was done.

There isn't a version tag on this task ?

I think the bot tags only the first ticket of any patch after it is merged

(Maybe we can check if this works on beta ?)

Tried. https://en.wikipedia.beta.wmflabs.org/wiki/T351618 is only linked by a redirect, but doesn't show as orphan in https://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed. Btw, if you are testing, you might need to do a null edit on an article for PageTriage to redo the orphan (and other) calculations