| Punith.nyk | |
| Nov 20 2023, 11:59 AM |
| F41522967: 2023-11-21 17-31-07.mp4 | |
| Nov 21 2023, 12:37 PM |
| F41521870: image.png | |
| Nov 20 2023, 11:59 AM |
when the user clicks set filter this appears:
Step:
1 https://en.wikipedia.org/wiki/Special:NewPagesFeed
2 click on set Filter button
3 click anywhere outside the set filter window
So when the user clicks anywhere outside the overlay window the setfilter window still stays intact.
what should actually happen: When a user clicks on any area outside the overlay, the overlay should save and then be dismissed.
I have seen this happening on many websites
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add close functionality for filters dialog on outside-click | mediawiki/extensions/PageTriage | master | +15 -1 |
This probably worth prototyping. I'm unsure if misclicks might cause issues, but it does seem like other OOUI and similar Codex UI is implementing this.
Git doesn't seem to track changes in some files: modules/ext.pageTriage.newPagesFeed.vue/components/ListFilterMenu.vue
You have not saved changes for that specific file (vscode gives you a dot icon beside each file if it has not been saved).
Change 1009405 had a related patch set uploaded (by Maunikashekar; author: Maunikashekar):
[mediawiki/extensions/PageTriage@master] Add close functionality for filters dialog on outside-click
This is one of the few interactions in the feed that hasn't been migrated to codex. I suggest that we consider moving mwe-vue-pt-control-dropdown to a dialog instead of customizing the behavior of this element further:
https://doc.wikimedia.org/codex/latest/components/demos/dialog.html
@Yash4357: Anyone can amend the existing proposed patch linked above. No need to ever ask. :)