Page MenuHomePhabricator

[Design] Night mode design spike
Closed, ResolvedPublic

Description

I want to take @Jdlrobson's demo and list all of the UI bugs it creates for each different approach for ~ 3 different pages. @ovasileva and I will then go through those bugs and give them each a priority ranking. The goal is that this will create a proxy for "how broken" templates become with each approach from a design perspective.

@DTorsani-WMF has agreed to help out as well with a sober second look in case I miss anything.

This should help communities understand the impact to UI quality each approach entails and whether one approach is better than the others in this regard.

Event Timeline

@JScherer-WMF https://patchdemo.wmflabs.org/wikis/2a7c033d11/wiki/Paris is out of date so let me create a new instance for this testing. When do you need it by?

@JScherer-WMF https://patchdemo.wmflabs.org/wikis/2a7c033d11/wiki/Paris is out of date so let me create a new instance for this testing. When do you need it by?

Today would be great, this week would be great, too. But I realize this is a mid-sprint addition, so also feel free to say no. :-)

Sorry didnt get time to do this. You can bug Jan to get an instance setup otherwise Ill circle back to this on Monday!

Sorry didnt get time to do this. You can bug Jan to get an instance setup otherwise Ill circle back to this on Monday!

@Jdrewniak if you have a few extra cycles, would you mind setting this up for me? I documented the FPO colours in T350030.

Jdlrobson renamed this task from Test UI bugs across dark mode approaches to [Design] Test UI bugs across dark mode approaches.Nov 27 2023, 7:01 PM

(Your colors should be live in that version)

JScherer-WMF renamed this task from [Design] Test UI bugs across dark mode approaches to [Design] Night mode design spike.Nov 30 2023, 5:39 PM

I outlined the results of this in the video here. You can see the screenshots of broken templates in Figma here

tl;dr:
The biggest common problems are

  • Text contrast ratios on backgrounds that expect black text.
  • Labels on SVGs (esp. maps)
  • Removing or distorting semantic and non-semantic colours in templates

These are all P0s for me.

I think the first and second issue are a fairly easy fix. If we ignore templates to start, we can ignore the night theme text colour in templates and they would remain accessible and accurate.

Broad thoughts:

  • I have started thinking about these challenges at 3 time horizons. Day 1 of beta, Day 1 of prod, and day 500 of prod. I think we should optimize for the solution that gets us the highest quality result at the longer time horizon rather than over-indexing on what gets us to beta the fastest.

@ovasileva @Jdrewniak ^

Take aways from watching the video:

  • Problems weren't as bad as Justin first thought
  • Many of these problems where templates inherit from content are easy to fix (some of these are also problems in light mode). e.g. labels on top of SVGs
  • We shouldn't change any semantic color (E.g. map legends, political party colors) programmatically (e.g. via invert) as it's misinformation.
  • Accessibility is more important than aesthetic
  • We should think about time horizons and should optimize for day 500 vs getting something better on day 1 - e.g. take our time to build something better.