Page MenuHomePhabricator
Create Task
Maniphest T351853

Regression [production]: Edit icons are not hidden in section headings
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Nov 22 2023, 10:32 PM
Tags
Referenced Files
F41561844: screenshot 163.mov.gif
Dec 5 2023, 6:21 AM
F41558449: screenshot 142.mov.gif
Dec 4 2023, 12:14 AM
F41524463: Screenshot 2023-11-22 at 2.33.00 PM.png
Nov 22 2023, 10:40 PM
F41524461: Screenshot 2023-11-22 at 2.31.47 PM.png
Nov 22 2023, 10:32 PM
Subscribers
Aklapper
Edtadros
Jdlrobson
matmarex
ovasileva

Description

NOTE: This regression appears to relate to the change in T346944 (merged October 23rd)

Steps to replicate the issue (include links if applicable):

  • Visit any article on mobile with pages collapsed.

What happens?:

Screenshot 2023-11-22 at 2.31.47 PM.png (911×670 px, 61 KB)

What should have happened instead?:
Previously all the edit icons were hidden until the section was opened

Screenshot 2023-11-22 at 2.33.00 PM.png (929×668 px, 99 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Beta

ACStatusDetails
1✅T351853#9377518

QA Results - Prod

ACStatusDetails
1✅T351853#9381717

Details

SubjectRepoBranchLines +/-
Restore section edit link stylesmediawiki/skins/MinervaNeuemaster+8 -11
Fixes: Edit icons are not hidden in section headingsmediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Nov 22 2023, 10:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 22 2023, 10:32 PM
Jdlrobson added projects: MinervaNeue, Web-Team-Backlog, Regression.Nov 22 2023, 10:40 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Nov 22 2023, 10:42 PM

Change 976873 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Fixes: Edit icons are not hidden in section headings

https://gerrit.wikimedia.org/r/976873

gerritbot added a project: Patch-For-Review.Nov 22 2023, 10:42 PM

Change 975349 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Restore section edit link styles

https://gerrit.wikimedia.org/r/975349

matmarex claimed this task.Nov 27 2023, 6:32 PM
gerritbot added a comment.Nov 27 2023, 7:11 PM

Change 976873 abandoned by Jdlrobson:

[mediawiki/skins/MinervaNeue@master] Fixes: Edit icons are not hidden in section headings

Reason:

https://gerrit.wikimedia.org/r/976873

Jdlrobson reassigned this task from matmarex to Edtadros.Nov 27 2023, 7:11 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4); removed Web-Team-Backlog.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
Jdlrobson added a subscriber: matmarex.
gerritbot added a comment.Nov 27 2023, 7:40 PM

Change 975349 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore section edit link styles

https://gerrit.wikimedia.org/r/975349

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.7; 2023-11-28).Nov 27 2023, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 8:11 PM
Edtadros removed Edtadros as the assignee of this task.Dec 4 2023, 12:14 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 4) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit any article on mobile with pages collapsed.
✅ AC1: ll the edit icons should be hidden until the section is opened

screenshot 142.mov.gif (728×336 px, 2 MB)

Edtadros updated the task description. (Show Details)Dec 4 2023, 12:15 AM
ovasileva closed this task as Resolved.Dec 4 2023, 9:53 AM
ovasileva claimed this task.
ovasileva subscribed.

Looks good, resolving.

Edtadros added a project: Verified.Dec 5 2023, 6:21 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit any article on mobile with pages collapsed.
✅ AC1: ll the edit icons should be hidden until the section is opened

screenshot 163.mov.gif (732×340 px, 722 KB)

Edtadros updated the task description. (Show Details)Dec 5 2023, 6:22 AM
Edtadros mentioned this in T351126: Verify 1.42.0-wmf.7 deployment.Dec 5 2023, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL