Page MenuHomePhabricator

Add Kiwix for iOS/macOS to translatewiki.net
Closed, ResolvedPublic4 Estimated Story Points

Description

Project information

Name: Kiwix Apple
Homepage: https://kiwix.org
Project link: Should be a subproject of Kiwix
Code repository: https://github.com/kiwix/apple

  • Source branch: main
  • Target branch: feature branch (to be merged on main)

OS License: GPLv3
Issue Tracker: https://github.com/kiwix/apple/issues
Project contact: Kelson

Logo: https://translatewiki.net/wiki/File:Kiwix_icon.svg

  • Without text:
  • With text:

Project description:
Launched 10 years ago, we are finally ready to localised the Kiwix version for iOS and macOS.

App should be now localized properly (see this PR) and should be OK for Translatewiki to indgest.

NOTE: Section below will be filled by twn staff

Project setup checklist

Project configuration (for translation admins)

Namespace: NS_KIWIX
Prefix: apple-
Validators: IosVariable, enforcable and insertable
Support: https://github.com/kiwix/apple/issues

id: kiwix-apple
label: Kiwix Apple
icon: wiki://Kiwix_icon.svg

Path to localization file: Support/en.lproj/Localizable.strings

Concerns

Event Timeline

@Kelson - Few questions:

  1. Do you want translatewiki to commit to feature branch and then create a PR to main branch?
  2. Does the translatewiki bot have access to commit to this project?
  3. Once the project is added on translatewiki, please add message documentation for the project.
  1. Do you want translatewiki to commit to feature branch and then create a PR to main branch?

yes, like for all other Kiwix/openZIM project handled at TW

  1. Does the translatewiki bot have access to commit to this project?

Not yet, but I just have invited the Translatewiki.net Github User to join

  1. Once the project is added on translatewiki, please add message documentation for the project.

I have created the ticket at https://github.com/kiwix/apple/issues/561. Do we have an example of macOS/iOS software with that?

Change 978052 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Add Kiwix-ios project to Translatewiki

https://gerrit.wikimedia.org/r/978052

Change 978052 merged by jenkins-bot:

[translatewiki@master] Add Kiwix-ios project to Translatewiki

https://gerrit.wikimedia.org/r/978052

Change 978614 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] KiwixApple: Load the group configuration file

https://gerrit.wikimedia.org/r/978614

Change 978614 merged by jenkins-bot:

[translatewiki@master] KiwixApple: Load the group configuration file

https://gerrit.wikimedia.org/r/978614

  1. Once the project is added on translatewiki, please add message documentation for the project.

I have created the ticket at https://github.com/kiwix/apple/issues/561. Do we have an example of macOS/iOS software with that?

See: https://github.com/wikimedia/wikipedia-ios/tree/main/Wikipedia/Localizations/qqq.lproj

Currently blocked on this due to: T352300: Newlines in "Apple" format not supported

@Kelson Our current implementation of Apple file format does not support multiline strings such as these

"loc-external-alert" = "An external link is tapped. \
However, your current setting does not allow it to be loaded.";
"loc-article-cell-template" = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, \
sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.";
"loc-ZimFileDetail-Alert-Delete" = "The zim file and all bookmarked articles \
linked to this zim file will be deleted.";

Would it be easy to avoid using of these literal new lines?

@abi_ We are working on it. See https://github.com/kiwix/apple/issues/571. I will come back to you within a few days when this will be done.

  1. Once the project is added on translatewiki, please add message documentation for the project.

I have created the ticket at https://github.com/kiwix/apple/issues/561. Do we have an example of macOS/iOS software with that?

See: https://github.com/wikimedia/wikipedia-ios/tree/main/Wikipedia/Localizations/qqq.lproj

Currently blocked on this due to: T352300: Newlines in "Apple" format not supported

Thank you, I really hope to get that fixed next week as well.

@Kelson Our current implementation of Apple file format does not support multiline strings such as these

"loc-external-alert" = "An external link is tapped. \
However, your current setting does not allow it to be loaded.";
"loc-article-cell-template" = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, \
sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.";
"loc-ZimFileDetail-Alert-Delete" = "The zim file and all bookmarked articles \
linked to this zim file will be deleted.";

Would it be easy to avoid using of these literal new lines?

@abi_ Hi, this should be fixed now in git main branch. Let me know please otherwise.

Change 980485 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Revert "Revert "KiwixApple: Load the group configuration file""

https://gerrit.wikimedia.org/r/980485

Change 980485 merged by jenkins-bot:

[translatewiki@master] Revert "Revert "KiwixApple: Load the group configuration file""

https://gerrit.wikimedia.org/r/980485

@Kelson Our current implementation of Apple file format does not support multiline strings such as these

"loc-external-alert" = "An external link is tapped. \
However, your current setting does not allow it to be loaded.";
"loc-article-cell-template" = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, \
sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.";
"loc-ZimFileDetail-Alert-Delete" = "The zim file and all bookmarked articles \
linked to this zim file will be deleted.";

Would it be easy to avoid using of these literal new lines?

@abi_ Hi, this should be fixed now in git main branch. Let me know please otherwise.

Thank you! The project is now available for translation: https://translatewiki.net/w/i.php?title=Special:Translate&group=kiwix-apple

Please confirm that the translatewiki bot has access to commit to the Kiwix Apple repository. Exports should roll out tomorrow.

Other than that, adding message documentation is pending.

The exports for Kiwix apple failed today

Error Output:                                                                
================                                                             
Cloning into '/scratch/exports/kiwix-apple'...                               
git@git@github.com: Permission denied (publickey).                           
fatal: Could not read from remote repository.                                
                                                                             
Please make sure you have the correct access rights                          
and the repository exists.

@abi_ I'm a bit puzzled by the situation. Translatewiki bot has access to the whole Kiwix organisation on Github and have good permissions for the kiwix/apple

image.png (810×2 px, 139 KB)

Your error reports a "read error" on a public git repository... might that be the repository name is not properly configured?

Error is in the config file: git@git@github.com:kiwix/apple.git, this is not a valid address.

Change 981943 had a related patch set uploaded (by Wangombe; author: Wangombe):

[translatewiki@master] Fix wrong Kiwix Apple github link

https://gerrit.wikimedia.org/r/981943

Change 981943 merged by jenkins-bot:

[translatewiki@master] Fix wrong Kiwix Apple github link

https://gerrit.wikimedia.org/r/981943

Error is in the config file: git@git@github.com:kiwix/apple.git, this is not a valid address.

Thanks for checking it out. We've submitted a fix and exports should happen later today.