Page MenuHomePhabricator

[WtC-M2] Replace WiKit tokens used in MSMF's Component files
Closed, ResolvedPublic5 Estimated Story Points

Description

Problem

The Mismatch Finder's user interface was styled using WiKit tokens. With the WiKit design system being superseded by Codex, the official Wikimedia design system. The utilization of WiKit tokens is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency.

Solution

We have to replace all WiKit tokens used to style the Mismatch Finder app.
This task focuses on the replacement of the deprecated tokens used in the project's Component files:

To support the replacement, here's a WiKit to Codex tokens mapping. You can find the WiKit tokens matched with their corresponding Codex token.

Considerations
  • Some of the files listed above contain spacing and layout tokens from WiKit. Their replacement depends on the creation of custom variables (see T350189)
  • MismatchesTable.vue was excluded because it doesn't contain tokens to replace
  • I believe LoadingOverlay.vue won't be used anymore in Mismatch finder. I'm not sure whether we use it anywhere in the store
  • The LanguageSelector component files were excluded: they contain several discrete values that should ideally be replaced by Codex tokens whenever possible. This work will be done as part of the future visual adjustment of this component to new guidelines (T345905)
  • Any WiKit component tokens used individually in the files will need to also be replaced by an equivalent Codex token
Acceptance criteria
  • All the WiKit tokens used in the MSMF Component files are replaced by their Codex equivalent

Event Timeline

noarave set the point value for this task to 5.Dec 5 2023, 12:08 PM
ItamarWMDE subscribed.

Task Breakdown Notes:

  • The three tasks (T352304, T352311, T352314) are probably dependent on each other for UX review so they must be done in parallel and reviewed at once (after all of them are done).
  • This would require some contact with Sarai on the review.
  • For tokens that do not have a codex equiv please refer to the Wikit Tokens Documentation.

All WiKit tokens were replaced by their correct equivalent and no visual issues were detected.

Please see this comment for an open question regarding the replacement of discrete values that might potentially affect this task.

A separate task to replace discrete values was created: T355520