The PR to the UI:
https://github.com/wbstack/ui/pull/760

Few things that I haven't done yet:

• When SAVE QUESTIONS is clicked, an error message should be displayed at the empty fields and prevent questions/answers to be saved if there are any empty fields
• RECOVER DEFAULT QUESTIONS doesn't seem to work
• some specs haven't matched the design yet

Hello! Looking great so far! 🥳 Here's my preliminary review. I'm aware that i'm checking early and some of the stuff you might have not tackled yet. That being said, here's a list of stuff that i noticed is not according to figma specs:

1. Checkbox dimensions are too big.
2. Spacing between checkbox and body text above is woo large
3. Trash can icon sits on bottom of text input component. Should be sitting aligned with the top of the text input component
4. I’m not able to verify the spacing between the last answer field and the +add question button. Can you let me know what that is? (should be 40px)
5. Unsure about the spacing between Q&A bundles (should be 40px)
6. Spacing between question and answer field is too large (should be 8px)
7. Save doesn’t work yet
8. Empty Q&A bundles are not discarded (under the condition that there's at least one valid Q&A bundle) on save but instead show error message
9. Trash icon not removed when only one Q&A bundle is left

Please check the Figma file for all the details on specs and desired behaviours. Thanks!

1. I believe it's the right dimension as the design. Are you sure it's too big?
2. Done
3. Done
4. fixed, it was 44px, 40px now
5. it's 40px now
6. done
7. done
8. done
9. consider it done

hey dat, thanks for addressing all the points, that's awesome!

some small things that i noticed when looking over it again:

1. the answer fields are slightly too long. they should always be the same size as the question fields (also in the case of a single Q&A bundle where the trashcan is removed which brings me to my second point)
2. when only one Q&A bundle is left, the dissapearance of the trashcan makes the question field jump in size. from my perspective we have three options: either both the question and answer field jump in size, the question field remains the same size as before, the trashcan only becomes disabled instead of disappearing. I don't mind which one you pick, as long as the Q and A field are always the same size.
3. after successfully saving, the setting expander should collapse again. currently it stays open
4. when i save the questions and then go back to my dashboard and then back to the questy-settings my saved questions are gone. not sure if that's because this is just a mock UI thingie or if that would also be the case in production. i didn't reload the page or anything, when trying this flow out.
5. when a field is in an error state (except for the situation where the entire bundle is empty but there's at least one valid bundle) then clicking save should result in the view scrolling up to the first field with an error. (hope that description makes sense, let me know if i can elaborate)

I looked at this by running it locally together with API v8x.34.1

Things I noticed:

• enabling/disabling the feature via the checkbox currently requires to press the button to save the questions (not sure if this is intentional)
• I think points 4 & 5 ("successfully loading saved questions" & "auto-scroll to the first error in the form") from Charlies last comment still need to be addressed:
  • currently it seems that the API response is not parsed correctly
  • no scrolling happens for me if there are some errors in the form

enabling/disabling the feature via the checkbox currently requires to press the button to save the questions (not sure if this is intentional)

As discussed in the daily today the desired behavior is that the checkbox/toggle to enable/disable the feature is supposed to

• trigger to save the change (enable/disable, but not the questions) as soon as it is toggled
• if there's an error, an error snackbar should appear like it already does for saving the questions
• in the case a user enables the feature for the first time, the default questions should get saved as well (even if the question form wasn't used)
• the checkbox should get turned into a toggle switch

In T352426#9472025, @Deniz_WMDE wrote:

enabling/disabling the feature via the checkbox currently requires to press the button to save the questions (not sure if this is intentional)

As discussed in the daily today the desired behavior is that the checkbox/toggle to enable/disable the feature is supposed to

• trigger to save the change (enable/disable, but not the questions) as soon as it is toggled
• if there's an error, an error snackbar should appear like it already does for saving the questions
• in the case a user enables the feature for the first time, the default questions should get saved as well (even if the question form wasn't used)
• the checkbox should get turned into a toggle switch

• toggle switch should never save any changes to the questions

I reviewed the PR again and approved it, as far as I can see everything we noticed is addressed now, nicely done!

Looks like this now ought to be able to go to staging where we can get another round of review from @Charlie_WMDE or she can give it before it gets there from the netlify preview

Yay, looks great to me! Thanks so much everyone, for this collaborative effort! <3