Page MenuHomePhabricator

Parsoid TOC edge case bugs
Closed, ResolvedPublic

Description

For now, I'll use this as a placeholder task for a bunch of TOC placement edge cases in Parsoid.

  1. See this viwiki page. Effectively, Parsoid adds the TOC marker to the end of the page because the lead section wraps the whole page because all other sections are embedded in a table. Strictly speaking that is the right section wrapping output, but the heuristic for adding the TOC marker (add before the lastChild of the lead section) doesn't work in this case.. For vector 2022, this bug doesn't matter because the TOC is pulled out to the size anyway, but it will matter for skins that display TOC inline.
  1. See Parsoid has a TOC whereas there is no TOC with current rendering. Again, some heuristic determining TOC placement failed here.

Event Timeline

Change 988712 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Fix edge case bug in TOC meta-tag generation

https://gerrit.wikimedia.org/r/988712

ssastry triaged this task as Medium priority.

Change 989618 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Ensure TOC Is inserted in the right place

https://gerrit.wikimedia.org/r/989618

Change 988712 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix edge case bug in TOC meta-tag generation

https://gerrit.wikimedia.org/r/988712

Change 989618 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Ensure TOC is inserted in the right place

https://gerrit.wikimedia.org/r/989618

Change 990630 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/services/parsoid@master] Avoid null in WrapSectionsState

https://gerrit.wikimedia.org/r/990630

Change 990630 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Avoid null in WrapSectionsState

https://gerrit.wikimedia.org/r/990630

Change 990732 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a13

https://gerrit.wikimedia.org/r/990732

Change 990732 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a13

https://gerrit.wikimedia.org/r/990732