Page MenuHomePhabricator

Owners phpunit test does not work with subfolders
Open, Needs TriagePublic

Description

Background

From @Jdlrobson:

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/+/977811, I separated click tracking code into a subfolder. When doing this I was surprised that I couldn't specific a directory in the Owners.md file and instead had to list out the file names. While these files are currently unique, this will not work if we ever introduce new subfolders with identical names.

Currently:

## Click-tracking for Vector and Minerva

* Since: July 2019
* Files: desktop.js, mobile.js, utils.js
* Contact: Readers Web

Details at <https://phabricator.wikimedia.org/T220016>.

Expected:

## Click-tracking for Vector and Minerva

* Since: July 2019
* Files: clickTracking/*
* Contact: Readers Web

Details at <https://phabricator.wikimedia.org/T220016>.

This seemed out of scope for the task I was working on so I hope you don't mind the separate ticket!

Acceptance Criteria

  • An instrument owner is able to document a subdirectory in a ResourceLoader module as being owned
  • An instrument owner is able to document a ResourceLoader module as being owned

Requirements

  • Unit/integration tests
  • Documentation
  • Passed QA?

Notes